Uploaded image for project: 'OpenShift Hive'
  1. OpenShift Hive
  2. HIVE-2624

Make modcheck fix problems (phase 1: require)

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Undefined Undefined
    • openshift-4.18
    • None
    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • None
    • None
    • None
    • None

      Today we have make modcheck in our verify flow. It compares the versions of dependencies in the root go.mod with those in apis/go.mod and fails if there are discrepancies. The idea is to force us to keep those dependencies in sync so that downstreams consuming apis/ get the same behavior we do natively.

      When make modcheck fails, our recourse is to manually copy the versions from one go.mod to the other (and then go mod tidy etc.). For convenience, we should be able to e.g. run make modfix which would run modcheck -f which would make the actual edits to apis/go.mod. This should all be relatively straightforward using the modfile library – though it'll take a little refactoring of the current modcheck.go.

              efried.openshift Eric Fried
              efried.openshift Eric Fried
              None
              None
              None
              None
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: