Uploaded image for project: 'OpenShift Hive'
  1. OpenShift Hive
  2. HIVE-2556

Add controlledByReplica printcolumn for ClusterSync

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Undefined Undefined
    • openshift-4.18
    • None
    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • None
    • None
    • None
    • None

      I feel like it would be useful to see the ordinal of the statefulset replica in tabular output for oc get clustersync. Something like this ought to do it:

      diff --git a/vendor/github.com/openshift/hive/apis/hiveinternal/v1alpha1/clustersync_types.go b/vendor/github.com/openshift/hive/apis/hiveinternal/v1alpha1/clustersync_types.go
      index 7f330d089..6145eb1be 100644
      --- a/apis/hiveinternal/v1alpha1/clustersync_types.go
      +++ b/apis/hiveinternal/v1alpha1/clustersync_types.go
      @@ -14,6 +14,7 @@ import (
       // +kubebuilder:subresource:status
       // +kubebuilder:resource:path=clustersyncs,shortName=csync,scope=Namespaced
       // +kubebuilder:printcolumn:name="Status",type=string,JSONPath=`.status.conditions[0].reason`
      +// +kubebuilder:printcolumn:name="ControllerReplica",type=string,JSONPath=`.status.controlledByReplica`
       // +kubebuilder:printcolumn:name="Message",type=string,priority=1,JSONPath=`.status.conditions[?(@.type=="Failed")].message`
       type ClusterSync struct {
              metav1.TypeMeta   `json:",inline"`
      

              efried.openshift Eric Fried
              efried.openshift Eric Fried
              None
              None
              Mingxia Huang Mingxia Huang
              None
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: