Uploaded image for project: 'OpenShift Hive'
  1. OpenShift Hive
  2. HIVE-2214

Add support for list/dict in value member of ClusterDeploymentCustomization

XMLWordPrintable

    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • None
    • None
    • None
    • None

      Description
      ClusterDeploymentCustomization allow us to patch install-config templates and customize its json paths per cluster deployment.
      The struct was created to represent a json patch as defined in RFC6902 althrough, in the CDC struct the "value" member is defined as String and does not accepts Lists or Dicts as defined in the RFC.
      This design block us from adding Lists and Dicts as customized values in our deployments.

      Example:

      apiVersion: hive.openshift.io/v1
      kind: ClusterDeploymentCustomization
      metadata:
        name: cdc-01
        namespace: test
      spec:
        installConfigPatches:
          - op: add
            path: /controlPlane/platform/openstack/additionalNetworkIDs
            value:
              - 56dc14b2-f3be-4919-bf91-61aa99832376
              - 96f637e8-6b43-462b-acf0-11ea1fd66e7b

      Acceptance Criteria
      1. ClusterDeploymentCustomization spec accepting dict/list values and applying them properly. openshift-installer is unmarshaling the JSON and installing the cluster with the provided customization.

       

              efried.openshift Eric Fried
              dviroel Douglas Viroel
              None
              None
              Mingxia Huang Mingxia Huang
              None
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: