Uploaded image for project: 'OpenShift Hive'
  1. OpenShift Hive
  2. HIVE-1955

Support for request redirection while using restconfig to enable use of PrivateEndpoint in ARO to reach OCP API server

XMLWordPrintable

    • False
    • None
    • False

      In ARO we are using PrivateEndpoints, part of PrivateLinkService https://docs.microsoft.com/en-us/azure/private-link/private-link-service-overview. We use the PrivateLink to enable maintenance on customer clusters.

      As part of the existing design, selected for its ability to support customer custom domains (not only default one), we are utilizing the DialContext e.g.

      restconfig.Dial = DialContext(privateEndpointAddress, privateEndpointPort) 

      This forward the requests to the right PrivateEndpoint IP address, but still allows for URL resolution on the customer cluster, so that the API server is properly reached.

      I have prepared the short gist with a snippet how it is done in the ARO

      // Extracted example how ARO uses dialcontext propert of restconfig 
      // to forward requests to cluster API server via privateEndpoint
      
      package main
      
      import (
          "context"
          "fmt"
          "net"
          "os"
          "time"    "k8s.io/client-go/tools/clientcmd"
      )
      
      func DialContext(privateEndpointAddress string, port string) func(ctx context.Context, network, address string) (net.Conn, error) {
          return func(ctx context.Context, network, address string) (net.Conn, error) {
              if network != "tcp" {
                  return nil, fmt.Errorf("unimplemented network %q", network)
              }        return (&net.Dialer{
                  Timeout:   30 * time.Second,
                  KeepAlive: 30 * time.Second,
              }).DialContext(ctx, network, privateEndpointAddress+":"+port)
          }
      }func main() {
          kubeconfig := os.Getenv("KUBECONFIG")
          privateEndpointAddress := os.Getenv("PE_ENDPOINT")
          privateEndpointPort := os.Getenv("PE_PORT")
          config, err := clientcmd.Load([]byte(kubeconfig))
          if err != nil {
              panic(err)
          }    
          
          restconfig, err := clientcmd.NewDefaultClientConfig(*config, &clientcmd.ConfigOverrides{}).ClientConfig()
          if err != nil {
              panic(err)
          }    
          
          restconfig.Dial = DialContext(privateEndpointAddress, privateEndpointPort)    
          
          return
      } 

      If for any reason the formatting is wrong the same gist https://gist.github.com/petrkotas/22e23e31b848581d908dd10e1f8981af

       

      Would you please provide the same configurable option to use the DialContext in HIVE? ARO would provide `kubeconfig`, `privateEndpointAddress` and `port`.

      Without this functionality the HIVE will not be able to reach customer clusters.

       

      Alternative designs have been considered, however none provided the required functionality.

       

       

       

              mihuang@redhat.com Mingxia Huang
              pkotas Petr Kotas
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Created:
                Updated:
                Resolved: