Uploaded image for project: 'HAL'
  1. HAL
  2. HAL-1810

The direct String constants ["add-circle-o" and "bottom"] could be defined in the UIConstants.

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • None
    • 3.6.4.Final
    • None
    • None

      In the ColumnActionFactory, The given methods [addButton() and add()] conntains the direct String constants values ["bottom" and "add-circle-o"] but those could be defined in the UIConstants.

      --------------------

       public HTMLElement addButton(String title, String iconCss)

      {         return span().css(iconCss)                 .title(title)                 .data(UIConstants.TOGGLE, UIConstants.TOOLTIP)                 .data(UIConstants.PLACEMENT, "bottom").element();     }

      public <T> ColumnAction<T> add(String id, String type, AddressTemplate template, ColumnActionHandler<T> handler)

      {         return add(id, type, template, pfIcon("add-circle-o"), handler);     }

      ---------------------

       

      Adding String constants to the 'UIConstants' and using in 'ColumnActionFactory'.

      [String constants]:

      --------

      String  ADD_CIRCLE_O = "add-circle-o";

      String BOTTOM = "bottom";

      --------

       

       

       

              rhn-support-saahamad Sarfaraz Ahamad
              rhn-support-saahamad Sarfaraz Ahamad
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: