-
Task
-
Resolution: Obsolete
-
Major
-
None
-
None
- Tons of "Failed prop type" warnings.
72 required props being undefined but also 4 type mismatches:Warning: Failed prop type: Invalid prop `initialValues.persistent_storage` of type `string` supplied to `ScaleClusterDialog`, expected `number`. Warning: Failed prop type: Invalid prop `addOns` of type `string` supplied to `ClusterDetails`, expected `object`. Warning: Failed prop type: Invalid prop `quota` of type `object` supplied to `LoadBalancersDropdown`, expected `number`. Warning: Failed prop type: Invalid prop `addClusterAddOnResponse` of type `function` supplied to `AddOns`, expected `object`.
Why do we bother with propTypes if we don't even heed them in tests? I think these 4 demonstrate we should heed them, but for that we need to reduce noise from required props (which might also indicate real problems)
- some warnings about input in EditConsoleURLDialog
- over 900 UnhandledPromiseRejectionWarning at the end.
side effect of the router tests testing connected components, I didn't want that to actually make network requests so there's a mock that rejects all requests with status 500. We could change the mock to resolve rather than reject and that'd silence these errors if they're too annoying
— Elad Alfassa on slack
- split to
-
OCMUI-596 [OCM UI] Unit tests: Fix PropType violations
- Closed
- mentioned on