-
Bug
-
Resolution: Done
-
Critical
-
None
-
None
-
False
-
False
-
None
-
HAC Infra - Sprint 224
The UI validation error messages are incorrect, or at least misleading
The subnet mask can't be lower than '/${AWS_MACHINE_CIDR_MIN}'.
Should be
The subnet mask can't be larger than '/${AWS_MACHINE_CIDR_MIN}'.
(CIDR notation can be confusing, smaller numbers indicate larger blocks of IPs)
https://gitlab.cee.redhat.com/service/uhc-portal/-/blob/master/src/common/validators.js#L466
Same logic follows with
- https://gitlab.cee.redhat.com/service/uhc-portal/-/blob/master/src/common/validators.js#L470
- higher -> smaller
- https://gitlab.cee.redhat.com/service/uhc-portal/-/blob/master/src/common/validators.js#L474
- higher -> smaller
- https://gitlab.cee.redhat.com/service/uhc-portal/-/blob/master/src/common/validators.js#L491
- higher -> smaller
- https://gitlab.cee.redhat.com/service/uhc-portal/-/blob/master/src/common/validators.js#L497
- higher -> smaller
- https://gitlab.cee.redhat.com/service/uhc-portal/-/blob/master/src/common/validators.js#L512
- higher -> smaller
- https://gitlab.cee.redhat.com/service/uhc-portal/-/blob/master/src/common/validators.js#L525
- higher -> smaller
- https://gitlab.cee.redhat.com/service/uhc-portal/-/blob/master/src/common/validators.js#L660
- lower -> larger
- https://gitlab.cee.redhat.com/service/uhc-portal/-/blob/master/src/common/validators.js#L664
- higher -> smaller
Finally, I believe the "which provides up to X nodes." logic in https://gitlab.cee.redhat.com/service/uhc-portal/-/blob/master/src/common/validators.js#L488-498 is wrong. I'm not sure what the proper validation is, but we should consider removing this part of the message until it's been properly vetted.
- is related to
-
OCMUI-720 [OCM Wizards] Machine CIDR validation cannot work for cloud provider GCP
- Closed
- mentioned on