Uploaded image for project: 'OpenShift GitOps'
  1. OpenShift GitOps
  2. GITOPS-9119

Inconsistent logformat #1821

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • None
    • Operator
    • 3
    • False
    • Hide

      None

      Show
      None
    • False
    • GitOps Crimson Sprint 29

      Story (Required)

      https://github.com/argoproj-labs/argocd-operator/issues/1821 

      Describe the bug
      The logFormat option is inconsistently written between components. Some have logfomat, some have logFormat.

      New options .spec.applicationSet.logformat and .spec.notifications.logformat were added in all lowercase.
      But existing option .spec.controller.logFormat and in .spec.server.logFormat and .spec.repo.logFormat, were written with a capital 'F'.
      This should be corrected to have argocd consistent options for logging: fieldnaming: logFormat

      Looking at the desription (e.g. bundle/provided by oc explain, the description writes format with capital F.
      So on that point there is more inconsistency.
      (eg. config/crd/bases/argoproj.io_argocds.yaml about at line 1483)

      So, were the latest 'logformat' field additions particularly written like that, or was it sloppy work?

      To Reproduce
      Steps to reproduce the behavior:

      1. oc explain argocd.spec.applicationSet -> logformat
      2. adding .spec.applicationSet.logformat works (but the field is inconsistent with logFormat from other argocd components.,
      3. adding .spec.applicationSet.logformat does NOT work

      Expected behavior
      logFormat should be written the same in all components.

       

      Additional context
      Having consistent fieldnames.

              rh-ee-tsoham Tejas Soham
              rh-ee-tsoham Tejas Soham
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: