Uploaded image for project: 'OpenShift GitOps'
  1. OpenShift GitOps
  2. GITOPS-8738

Deprecate Prometheus CR functionality in operator, without touching ServiceMonitor/PrometheusRule

XMLWordPrintable

    • GitOps Scarlet Sprint 28

      Background and Approach (Required)

      See parent epic for details

      Acceptance Criteria (Mandatory)

      • From now on, when user has specified `.spec.prometheus.enabled`, we should NOT create the Prometheus CR.
      • If the Prometheus CR exists (whether `.spec.prometheus.enabled` is true/false/undefined) we should delete it.
      • If the Prometheus Service/Route/Ingress exists, we should delete them.
      • E2E test in argocd-operator to verify deletion works as expected
      • Add comments in `ArgoCDPrometheusSpec` to Host/Ingress/Route/Size fields indicating that the field is deprecated and no longer used.
      • Remove documentation from docs/ in argocd-operator repo that refers to the A) and B) funtionality described above (for example, see insights.md)
      • Note, as above, the following functionality should continue to work when .spec.prometheus.enabled is true:
        • ServiceMonitors created by, for example, reconcileMetricsServiceMonitor/reconcileRepoServerServiceMonitor/reconcileServerMetricsServiceMonitor
        • PrometheusRules created by, for example, reconcilePrometheusRule

      Definition of Done

      • Code Complete:
        • All code has been written, reviewed, and approved.
      • Tested:
        • Unit tests have been written and passed.
        • Ensure code coverage is not reduced with the changes.
        • Integration tests have been automated.
        • System tests have been conducted, and all critical bugs have been fixed.
        • Tested and merged on OpenShift either upstream or downstream on a local build.
      • Documentation:
        • User documentation or release notes have been written (if applicable).
      • Build:
        • Code has been successfully built and integrated into the main repository / project.
        • Midstream changes (if applicable) are done, reviewed, approved and merged.
      • Review:
        • Code has been peer-reviewed and meets coding standards.
        • All acceptance criteria defined in the user story have been met.
        • Tested by reviewer on OpenShift.
      • Deployment:
        • The feature has been deployed on OpenShift cluster for testing.

              rh-ee-rnaaz Rizwana Naaz
              jgwest Jonathan West
              Scarlet
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: