Uploaded image for project: 'OpenShift GitOps'
  1. OpenShift GitOps
  2. GITOPS-8690

Argo CD Agent: version string output on startup is inaccurate in openshift gitops argocd agent builds

XMLWordPrintable

    • 5
    • False
    • Hide

      None

      Show
      None
    • False
    • GitOps Scarlet Sprint 27

      Description of Problem

      Argo CD Agent container in openshift gitops v1.19.x outputs this text:

      time="2026-01-09T10:32:38Z" level=info msg="Starting argocd-agent (server) v0.0.1-alpha (ns=principal-argocd, allowed_namespaces=[*])" module=server
      

      Notice the 'v0.0.1-alpha'. It should read 0.5.3, to correspond to the upstream argocd-agent version.

      See this Slack thread for details: https://redhat-internal.slack.com/archives/C01RQH8KQ87/p1767955435616869

      This is because we need to update the Dockerfile used to build the argocd-agent container in konflux.

      This is the file that needs to be updated:

      This is the file that that the above Dockerfile needs to be updated to look like:

      Specifically note that we are calling 'make' directly in the upstream case (which we want), but NOT calling make in the downstream case.

      HOWEVER, in the downstream case, we do still need these env vars/tags, for FIPS compliance:

      • 'CGO_ENABLED=1 GOEXPERIMENT=strictfipsruntime go build -tags strictfipsruntime'

      You may need to modify the upstream makefile to allow arbitrary env vars/args to be added.

      Acceptance Criteria

      • Downstream Makefile still includes FIPS/CGO values
      • Downstream Makefile calls 'make argocd-agent' similar to upstream

      Definition of Done

      • Code Complete:
        • All code has been written, reviewed, and approved.
      • Tested:
        • Unit tests have been written and passed.
        • Ensure code coverage is not reduced with the changes.
        • Integration tests have been automated.
        • System tests have been conducted, and all critical bugs have been fixed.
        • Tested and merged on OpenShift either upstream or downstream on a local build.
      • Documentation:
        • User documentation or release notes have been written (if applicable).
      • Build:
        • Code has been successfully built and integrated into the main repository / project.
        • Midstream changes (if applicable) are done, reviewed, approved and merged.
      • Review:
        • Code has been peer-reviewed and meets coding standards.
        • All acceptance criteria defined in the user story have been met.
        • Tested by reviewer on OpenShift.
      • Deployment:
        • The feature has been deployed on OpenShift cluster for testing.

              Unassigned Unassigned
              jgwest Jonathan West
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: