Description of Problem

Setting up agent using agent-helm-build by konflux (quay.io/redhat-user-workloads/rh-openshift-gitops-tenant/agent-helm-build, version 0.1.529-591bcce) fails due to  InvalidImageName error in agent pod. 

Additional Info

helm install command succeeds but the pod fails with InvalidImageName error

$ helm install argocd-agent oci://quay.io/redhat-user-workloads/rh-openshift-gitops-tenant/agent-helm-build  --version 0.1.529+591bcce --set logLevel="debug" --set agentMode=${mode} --set server=$route --set namespaceOverride=argocd
Pulled: quay.io/redhat-user-workloads/rh-openshift-gitops-tenant/agent-helm-build:0.1.529_591bcce
Digest: sha256:4df7e77c9281b6d5f08dc07e2ddc8b85fbb88285d0b70e52459a08752696b8c9
quay.io/redhat-user-workloads/rh-openshift-gitops-tenant/agent-helm-build:0.1.529_591bcce contains an underscore.

OCI artifact references (e.g. tags) do not support the plus sign (+). To support
storing semantic versions, Helm adopts the convention of changing plus (+) to
an underscore (_) in chart version tags when pushing to a registry and back to
a plus (+) when pulling from a registry. 
.
.
.

Pod yaml snippet:

.
.
.
    state:
      waiting:
        message: 'Failed to apply default image tag "quay.io/redhat-user-workloads/rh-openshift-gitops-tenant/argocd-agent-rhel8:''main''":
          couldn''t parse image name "quay.io/redhat-user-workloads/rh-openshift-gitops-tenant/argocd-agent-rhel8:''main''":
          invalid reference format'
        reason: InvalidImageName
.
. 

Pod logs:

$ oc logs -f argocd-agent-agent-5cd64fd58-6jvcl -n argocd
Error from server (BadRequest): container "argocd-agent-agent" in pod "argocd-agent-agent-5cd64fd58-6jvcl" is waiting to start: InvalidImageName  

Problem Reproduction

• Enable agent using quay.io/redhat-user-workloads/rh-openshift-gitops-tenant/agent-helm-build

Reproducibility

• Always

Prerequisites/Environment

• Regular OCP, GitOps 1.19 RC 

Steps to Reproduce

• Install 1.19 RC
• Use the helm install command to install agent on it

helm install argocd-agent oci://quay.io/redhat-user-workloads/rh-openshift-gitops-tenant/agent-helm-build  --version 0.1.529+591bcce --set logLevel="debug" --set agentMode=${mode} --set server=$route --set namespaceOverride=argocd 

Expected Results

• Agent pod is up and running 

Actual Results

• Agent pod fails with InvalidImageName error

Problem Analysis

• <Completed by engineering team as part of the triage/refinement process>

Root Cause

• <What is the root cause of the problem? Or, why is it not a bug?>

Workaround (If Possible)

• <Are there any workarounds we can provide to the customers?>

Fix Approaches

• <If we decide to fix this bug, how will we do it?>

Acceptance Criteria

• ...

Definition of Done

• Code Complete:
  • All code has been written, reviewed, and approved.
• Tested:
  • Unit tests have been written and passed.
  • Ensure code coverage is not reduced with the changes.
  • Integration tests have been automated.
  • System tests have been conducted, and all critical bugs have been fixed.
  • Tested and merged on OpenShift either upstream or downstream on a local build.
• Documentation:
  • User documentation or release notes have been written (if applicable).
• Build:
  • Code has been successfully built and integrated into the main repository / project.
  • Midstream changes (if applicable) are done, reviewed, approved and merged.
• Review:
  • Code has been peer-reviewed and meets coding standards.
  • All acceptance criteria defined in the user story have been met.
  • Tested by reviewer on OpenShift.
• Deployment:
  • The feature has been deployed on OpenShift cluster for testing.