Uploaded image for project: 'OpenShift GitOps'
  1. OpenShift GitOps
  2. GITOPS-7331

operator controller logs error when console link is disabled

XMLWordPrintable

    • 3
    • False
    • Hide

      None

      Show
      None
    • False
    • Hide
      Before this update, when DISABLE_DEFAULT_ARGOCD_CONSOLELINK was set to true and the ConsoleLink resource did not exist, the operator logged an error even though everything was working correctly. This update fixes the issue by preventing the operator from logging an error in this scenario. Now, when the ConsoleLink is disabled and absent, no misleading error log is shown.
      Show
      Before this update, when DISABLE_DEFAULT_ARGOCD_CONSOLELINK was set to true and the ConsoleLink resource did not exist, the operator logged an error even though everything was working correctly. This update fixes the issue by preventing the operator from logging an error in this scenario. Now, when the ConsoleLink is disabled and absent, no misleading error log is shown.
    • 3
    • GitOps Crimson Sprint 20

      Description of Problem

      Slack reported: https://redhat-internal.slack.com/archives/CMP95ST2N/p1753184037983959 

       

      If the ArgoCD console link is disabled in OCP console following [1] , the openshift-gitops-operator-controller-manager pod logs an error on every reconciliation loop

       

      2025-07-22T11:25:10Z    ERROR   controller_argocd_route ConsoleLink not found   {"Request.Namespace": "openshift-gitops", "Request.Name": "openshift-gitops-server", "ConsoleLink.Name": "argocd", "error": "ConsoleLink.console.openshift.io \"argocd\" not found"}
      github.com/redhat-developer/gitops-operator/controllers.(*ReconcileArgoCDRoute).Reconcile
              /remote-source/app/controllers/argocd_controller.go:155
      sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Reconcile
              /remote-source/deps/gomod/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:119
      sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
              /remote-source/deps/gomod/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:316
      sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
              /remote-source/deps/gomod/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:266
      sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2
              /remote-source/deps/gomod/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:227 

       

      [1] https://docs.redhat.com/en/documentation/red_hat_openshift_gitops/1.15/html/argo_cd_instance/setting-up-argocd-instance

      Additional Info

      If the console link is disabled and the console link resource is not found, the controller should return without any error.
      https://github.com/redhat-developer/gitops-operator/blob/41cfddb33a7f8687e3f8eaf2d9609801f06792e2/controllers/argocd_controller.go#L155

      Problem Reproduction

      • Observer error in gitops-operator-controller-manager pod 

        Reproducibility

      • <Always/Intermittent/Only Once>

      Prerequisites/Environment

      • <OpenShift, managed service (e.g., ROSA, ARO), operators, layered product, and other software versions, build details>

      Steps to Reproduce

      • ...

      Expected Results

      • ...

      Actual Results

      • ...

      Problem Analysis

      • <Completed by engineering team as part of the triage/refinement process>

      Root Cause

      • <What is the root cause of the problem? Or, why is it not a bug?>

      Workaround (If Possible)

      • <Are there any workarounds we can provide to the customers?>

      Fix Approaches

      • <If we decide to fix this bug, how will we do it?>

      Acceptance Criteria

      • ...

      Definition of Done

      • Code Complete:
        • All code has been written, reviewed, and approved.
      • Tested:
        • Unit tests have been written and passed.
        • Ensure code coverage is not reduced with the changes.
        • Integration tests have been automated.
        • System tests have been conducted, and all critical bugs have been fixed.
        • Tested and merged on OpenShift either upstream or downstream on a local build.
      • Documentation:
        • User documentation or release notes have been written (if applicable).
      • Build:
        • Code has been successfully built and integrated into the main repository / project.
        • Midstream changes (if applicable) are done, reviewed, approved and merged.
      • Review:
        • Code has been peer-reviewed and meets coding standards.
        • All acceptance criteria defined in the user story have been met.
        • Tested by reviewer on OpenShift.
      • Deployment:
        • The feature has been deployed on OpenShift cluster for testing.

              nmirasch@redhat.com Neus Miras Chueca
              rh-ee-sghadi Siddhesh Ghadi
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: