Uploaded image for project: 'OpenShift GitOps'
  1. OpenShift GitOps
  2. GITOPS-7035

ImageUpdater: Upgrade distribution/distribution dependency

XMLWordPrintable

    • 5
    • False
    • Hide

      None

      Show
      None
    • False

      Story (Required)

      github.com/distribution/distribution/v3/manifest/schema1 package (https://github.com/distribution/distribution/releases) has been deprecated and then removed from distribution/distribution module. In image-updater, there are several places that still use it. In order to bypass lint check, these places are annotated with //nolint:staticcheck. Once we upgrade to newer version of distribution/distribution module that no longer contains this package, these files will no longer compile.

      • pkg/registry/client.go
      • pkg/registry/client_test.go
      • pkg/registry/registry_test.go
      • pkg/argocd/update_test.go
      • registry-scanner/pkg/registry/client.go
      • registry-scanner/pkg/registry/client_test.go
      • registry-scanner/pkg/registry/registry_test.go

      Background and Approach (Required)

      • <Describes the context or background related to this story. Include deeper motivation of user/persona if relevant (5 whys)>
      • <Description of the general technical path on how to achieve the goal of the story. Include details like JSON schema, class definitions.>

      Out of Scope

      • <Defines what is not included in this story.>

      Dependencies

      • <Describes what this story depends on. Dependent stories and EPICs should be linked to the story.>

      Acceptance Criteria (Mandatory)

      • <Describe edge cases to consider when implementing the story and defining tests.>
      • <Provides a required and minimum list of acceptance tests for this story. More is expected as the engineer implements this story.>

      Definition of Done

      • Code Complete:
        • All code has been written, reviewed, and approved.
      • Tested:
        • Unit tests have been written and passed.
        • Ensure code coverage is not reduced with the changes.
        • Integration tests have been automated.
        • System tests have been conducted, and all critical bugs have been fixed.
        • Tested and merged on OpenShift either upstream or downstream on a local build.
      • Documentation:
        • User documentation or release notes have been written (if applicable).
      • Build:
        • Code has been successfully built and integrated into the main repository / project.
        • Midstream changes (if applicable) are done, reviewed, approved and merged.
      • Review:
        • Code has been peer-reviewed and meets coding standards.
        • All acceptance criteria defined in the user story have been met.
        • Tested by reviewer on OpenShift.
      • Deployment:
        • The feature has been deployed on OpenShift cluster for testing.

              rh-ee-ccoco Christopher Coco (Inactive)
              rh-ee-ccoco Christopher Coco (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: