-
Story
-
Resolution: Done
-
Undefined
-
None
-
None
-
5
-
False
-
-
False
-
-
-
GitOps Scarlet Sprint 16, GitOps Scarlet Sprint 17, GitOps Scarlet Sprint 18, GitOps Scarlet Sprint 19, GitOps Scarlet Sprint 20
Story (Required)
- As an OpenShift GitOps user, I want to exclude well known resources created by controllers and resources having high churn to be excluded by Argo CD application controller, so that it does not waste resources watching these resources. This feature is available in upstream Argo CD and needs to be made available in OpenShift GitOps as well.
Background and Approach (Required)
- Upstream Argo CD has excluded certain resources that are managed by controllers by default.
Check this link for the diff introduced in argocd-cm configmap
https://github.com/argoproj/argo-cd/commit/335b65baf88c4c7155f851bb3450f72d4800a355#diff-d4871b2556f24756487ca6be13230ab1bcba17792d8fca91ca138d9b9727f614
https://github.com/argoproj/argo-cd/pull/21760
https://github.com/argoproj/argo-cd/pull/21635
Out of Scope
N/A
Dependencies
- Depends on Argo CD v3.0.0 release.
Approach
- In the argocd-operator, pre-fill these configurations when creating the argocd-cm config map as a default value and override the default value by any customer updated values for these settingsĀ provided either via ArgoCD.spec.extraConfig.resource\.inclusions or ArgoCD.spec.resourceInclusions
Acceptance Criteria (Mandatory)
- resource.exclusions field is pre-filled in argocd-cm configmap by default when OpenShift GitOps managed Argo CD instance is created.
Definition of Done
- Code Complete:
- All code has been written, reviewed, and approved.
- Tested:
- Unit tests have been written and passed.
- Ensure code coverage is not reduced with the changes.
- Integration tests have been automated.
- System tests have been conducted, and all critical bugs have been fixed.
- Tested and merged on OpenShift either upstream or downstream on a local build.
- Documentation:
- User documentation or release notes have been written (if applicable).
- Build:
- Code has been successfully built and integrated into the main repository / project.
- Midstream changes (if applicable) are done, reviewed, approved and merged.
- Review:
- Code has been peer-reviewed and meets coding standards.
- All acceptance criteria defined in the user story have been met.
- Tested by reviewer on OpenShift.
- Deployment:
- The feature has been deployed on OpenShift cluster for testing.