Description of Problem

• GITOPS-5200, After the fix, extraCommandArgs is not accepting multiple entries of same command for same and even for different values.
• Due the above fix, commands like `--metrics-application-labels` cannot be added with multiple different values.

Additional Info

• Using it like below does add it in pod yaml but it doesn't work as expected

spec:
  controller:
    extraCommandArgs:
    - --metrics-application-labels
    - application.argoproj.io/template-version
    - application.argoproj.io/chart-version 
 

Reproducibility

• Always

Prerequisites/Environment

• OpenShift GitOps v1.16.0

Steps to Reproduce

• Update `spec.controller.extraCommandArgs` like below:

spec:
  controller:
    extraCommandArgs:
    - --metrics-application-labels
    - application.argoproj.io/template-version
    - --metrics-application-labels
    - application.argoproj.io/chart-version

Expected Results

• in controller pod yaml

containers:
  - command:
    - argocd-application-controller
    [...]
    - --metrics-application-labels
    - application.argoproj.io/template-version
    - --metrics-application-labels 
    - application.argoproj.io/chart-version

Actual Results

• in controller pod yaml

containers:
  - command:
    - argocd-application-controller
    [...]
    - --metrics-application-labels 
    - application.argoproj.io/chart-version

Problem Analysis

• <Completed by engineering team as part of the triage/refinement process>

Root Cause

• GITOPS-5200, After the bug fix  extraCommandArgs is not accepting multiple entries of same command for same and even for different values.

Workaround (If Possible)

• No

Fix Approaches

• <If we decide to fix this bug, how will we do it?>

Acceptance Criteria

• ...

Definition of Done

• Code Complete:
  • All code has been written, reviewed, and approved.
• Tested:
  • Unit tests have been written and passed.
  • Ensure code coverage is not reduced with the changes.
  • Integration tests have been automated.
  • System tests have been conducted, and all critical bugs have been fixed.
  • Tested and merged on OpenShift either upstream or downstream on a local build.
• Documentation:
  • User documentation or release notes have been written (if applicable).
• Build:
  • Code has been successfully built and integrated into the main repository / project.
  • Midstream changes (if applicable) are done, reviewed, approved and merged.
• Review:
  • Code has been peer-reviewed and meets coding standards.
  • All acceptance criteria defined in the user story have been met.
  • Tested by reviewer on OpenShift.
• Deployment:
  • The feature has been deployed on OpenShift cluster for testing.