Uploaded image for project: 'OpenShift GitOps'
  1. OpenShift GitOps
  2. GITOPS-6679

Operator doesn't support Banner's permanent property

XMLWordPrintable

    • Make UI configuration a first-class field in the Operator
    • False
    • Hide

      None

      Show
      None
    • False
    • In Progress
    • 0% To Do, 0% In Progress, 100% Done
    • Hide
      This enhancement introduces support for the permanent and position UI properties within the spec.banner field in ArgoCD CR, providing users with more granular control over banner display configurations in Argo CD UI.

      .spec.banner.permanent: A boolean field, when set to true, prevents the user from being able to dismiss the banner.

      .spec.banner.position: A string field that specifies where the banner should be displayed. Supported values are "top" and "bottom".
      Show
      This enhancement introduces support for the permanent and position UI properties within the spec.banner field in ArgoCD CR, providing users with more granular control over banner display configurations in Argo CD UI. .spec.banner.permanent: A boolean field, when set to true, prevents the user from being able to dismiss the banner. .spec.banner.position: A string field that specifies where the banner should be displayed. Supported values are "top" and "bottom".
    • Enhancement

      Found this during 1.16 testing

      Operator doesn't support Banner's permanent property.

      The permanent property technically was a feature enhancement done in Argo CD, but the discrepancy between what the Operator provides and which Argo CD version it supports (or we claim we support) can be considered a bug.

      Also, position is missing too

      https://github.com/argoproj-labs/argocd-operator/blob/a0b3b74082b7a6fcc13b37977e213a10cb85faf1/api/v1alpha1/argocd_types.go#L945

      The workaround is to use extraConfig but that makes these properties second level citizens:
       

      extraConfig:
        ui.bannerpermanent: 'true'
        ui.bannerposition: bottom

       

      Approach:

      Introduce a new spec.ui field in the ArgoCD CR to configure UI-related settings. These values will be mapped to the argocd-cm ConfigMap.

      The Operator already supports setting UI configs via spec.extraConfig. To maintain backward compatibility, if a value is set in both spec.ui and extraConfig, the value from extraConfig will take priority.

        1. Screenshot 2025-03-28 at 9.40.53 AM.png
          Screenshot 2025-03-28 at 9.40.53 AM.png
          385 kB
        2. bottomPermanent.png
          bottomPermanent.png
          377 kB

              rhn-support-alkumari Alka Kumari
              kykchong@redhat.com Keith Chong
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: