Story (Required)

• This story aims at code change which would set .status.conditions[Reconciled] field to `false` when the ArgoCD instance is in `Failed` state

Background and Approach (Required)

• While the current approach of setting .status.conditions[Reconciled] to true unless there is reconciliation failures is consistent with the feature as envisioned, it seems a little contradicting that the phase is in Failed but the Reconciled is true

Out of Scope

• Fixing SSO issue- not returning the error and just logging (which causes the  .status.conditions[Reconciled] to be in True with with sso: Failed) 

Dependencies

• None

Acceptance Criteria (Mandatory)

• ArgoCD in 'Failed' phase should set .status.conditions[Reconciled] as false

Definition of Done

• Code Complete:
  • All code has been written, reviewed, and approved.
• Tested:
  • Unit tests have been written and passed.
  • Ensure code coverage is not reduced with the changes.
  • Integration tests have been automated.
  • System tests have been conducted, and all critical bugs have been fixed.
  • Tested and merged on OpenShift either upstream or downstream on a local build.
• Documentation:
  • User documentation or release notes have been written (if applicable).
• Build:
  • Code has been successfully built and integrated into the main repository / project.
  • Midstream changes (if applicable) are done, reviewed, approved and merged.
• Review:
  • Code has been peer-reviewed and meets coding standards.
  • All acceptance criteria defined in the user story have been met.
  • Tested by reviewer on OpenShift.
• Deployment:
  • The feature has been deployed on OpenShift cluster for testing.