Upgrade testing steps for QE

Scenario 1: User removes unsupported configuration before upgrade

1. Install older version of GitOps Operator (v1.14 or v1.13)
2. Modify default openshift-gitops ArgoCD CR  

   apiVersion: argoproj.io/v1beta1
   kind: ArgoCD
   metadata:
     name: openshift-gitops
     namespace: openshift-gitops
   spec:
     server:
       route:
         enabled: true
         tls:
           insecureEdgeTerminationPolicy: None  # configuration under test
           termination: reencrypt 

1. Perform an upgrade to v1.15
2. Verify openshift-gitops ArgoCD status is as expected  

   status:
     applicationController: Running
     applicationSetController: Running
     phase: Available 
     redis: Running
     repo: Running
     server: Running
     sso: Running

1. Verify Argo CD UI is accessible via Route

Scenario 2: User upgrades with unsupported configuration

1. Install older version of GitOps Operator (v1.14 or v1.13)
2. Modify default openshift-gitops ArgoCD CR  

   apiVersion: argoproj.io/v1beta1
   kind: ArgoCD
   metadata:
     name: openshift-gitops
     namespace: openshift-gitops
   spec:
     server:
       route:
         enabled: true
         tls:
           insecureEdgeTerminationPolicy: Disable  # unsupported configuration under test
           termination: reencrypt 

1. Perform an upgrade to v1.15
2. Observe following error in Operator manager pod in openshift-gitops-operator namespace 

   2024-11-07T04:54:17Z ERROR Reconciler error {"controller": "argocd", "controllerGroup": "argoproj.io", "controllerKind": "ArgoCD", "ArgoCD": {"name":"openshift-gitops","namespace":"openshift-gitops"}, "namespace": "openshift-gitops", "name": "openshift-gitops", "reconcileID": "7d9d3028-7b0d-434b-94d0-696fefa2dae2", "error": "Route.route.openshift.io \"openshift-gitops-server\" is invalid: spec.tls.insecureEdgeTerminationPolicy: Invalid value: \"Disable\": invalid value for InsecureEdgeTerminationPolicy option, acceptable values are None, Allow, Redirect, or empty"}
   2672 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
   2673 /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:329
   2674 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
   2675 /go/pkg/mod/sigs.k8s.io/controller-runtime@v0.17.2/pkg/internal/controller/controller.go:266
   2676 sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func2.2

1. Update unsupported config in openshift-gitops ArgoCD CR 

   apiVersion: argoproj.io/v1beta1
   kind: ArgoCD
   metadata:
     name: openshift-gitops
     namespace: openshift-gitops
   spec:
     server:
       route:
         enabled: true
         tls:
           insecureEdgeTerminationPolicy: None  # Change Disable to None
           termination: reencrypt 

1. Observer Operator manager pod logs in openshift-gitops-operator namespace. Should no longer throw error from step 4.
2. Verify openshift-gitops ArgoCD status is as expected  

   status:
     applicationController: Running
     applicationSetController: Running
     phase: Available 
     redis: Running
     repo: Running
     server: Running
     sso: Running

1. Verify Argo CD UI is accessible via Route