A progressive rollout enabled ApplicationSet sometimes get's stuck between rollout steps.

The applicationset conditions seem to continuously flip between the following, seems like the controller does not append these but keeps overwriting itself:

...
  - lastTransitionTime: '2023-01-29T22:35:24Z'
    message: Successfully generated parameters for all Applications
    reason: ParametersGenerated
    status: 'True'
    type: ParametersGenerated
...
...
  - lastTransitionTime: '2023-01-29T22:34:44Z'
    message: ApplicationSet Rollout Rollout started
    reason: ErrorOccurred
    status: 'False'
    type: ParametersGenerated
...

It seems to be caused by the controller calling r.setApplicationSetStatusCondition here with the paramtersGenerated argument set to false and then the controller within the same reconcile calls the function again here (maybe) with the parametersGenerated set to true which overwrites the progressive condition.

To Reproduce

Apply this applicationset.yaml. If the applicationset progressive sync works, try deleting the applicationset and re-applying it a few times.

Expected behavior

All applications rollout successfully.

Upstream Reference

https://github.com/argoproj/argo-cd/issues/12202