-
Bug
-
Resolution: Done
-
Normal
-
None
-
None
-
5
-
GitOps Tangerine Sprint 12
Description of Problem
Operator adds `app.kubernetes.io/part-of: argocd` label on all it's managed resources. However for appset resources this label value is
`argocd-applicationset` and not `argocd`. Not sure about the reason but the upstream uses `argocd` for this label in appset resources so we should follow the same in operator. Also check if any other resources are missing this label and handle that as part of this ticket.
Additional Info
- label value set of appset: https://github.com/argoproj-labs/argocd-operator/blob/0ffa69ea6872500b647bc927ff7b3661918611a8/controllers/argocd/applicationset.go#L892-L896
Problem Reproduction
- Create a ArgoCD CR and enable applicationset
- Check the labels on applicationset resources like serviceaccount, roles, rolebinding
- Also enable other components and check for the `app.kubernetes.io/part-of` label on it's resources.
Reproducibility
- Always
Prerequisites/Environment
- <OpenShift, managed service (e.g., ROSA, ARO), operators, layered product, and other software versions, build details>
Steps to Reproduce
- ...
Expected Results
- ...
Actual Results
- ...
Problem Analysis
- <Completed by engineering team as part of the triage/refinement process>
Root Cause
- <What is the root cause of the problem? Or, why is it not a bug?>
Workaround (If Possible)
- <Are there any workarounds we can provide to the customers?>
Fix Approaches
- <If we decide to fix this bug, how will we do it?>
Acceptance Criteria
- ...
Definition of Done
- Code Complete:
- All code has been written, reviewed, and approved.
- Tested:
- Unit tests have been written and passed.
- Ensure code coverage is not reduced with the changes.
- Integration tests have been automated.
- System tests have been conducted, and all critical bugs have been fixed.
- Tested and merged on OpenShift either upstream or downstream on a local build.
- Documentation:
- User documentation or release notes have been written (if applicable).
- Build:
- Code has been successfully built and integrated into the main repository / project.
- Midstream changes (if applicable) are done, reviewed, approved and merged.
- Review:
- Code has been peer-reviewed and meets coding standards.
- All acceptance criteria defined in the user story have been met.
- Tested by reviewer on OpenShift.
- Deployment:
- The feature has been deployed on OpenShift cluster for testing.