Description of Problem

We started seeing this errors since v1.14.0, when the operator status was switching between installReady and Failed. This was happening after running the kuttl tests, mostly after the upgrades.

install strategy failed: Deployment.apps "openshift-gitops-operator-controller-manager" is invalid: spec.template.spec.containers[0].env[26].name: Required value 

This was observed during 1.14.2 testing against ocp 4.12 after running upgrade test with kuttl

install strategy failed: Deployment.apps "openshift-gitops-operator-controller-manager" is invalid: [spec.template.spec.containers[0].env[26].name: Required value, spec.template.spec.containers[0].env[27].name: Required value, spec.template.spec.containers[0].env[28].name: Required value, spec.template.spec.containers[0].env[29].name: Required value, spec.template.spec.containers[0].env[30].name: Required value, spec.template.spec.containers[0].env[31].name: Required value] 

After further investigation, we found 4-5 duplicate environment variables in the CSV, which we were not able to remove after deleting the controller deployement which did not get reconciled due to these errors.

It seems we are allowed to make modifications directly to the CSV and it even allows duplication.With higher OCP versions, duplication of env variables is not possible.

Additional Info

• <Any additional info such as logs, must-gather outputs, etc.>

Problem Reproduction

• Install the operator
• Run the KuTT tests

Reproducibility

• Intermittent

Prerequisites/Environment

• OCP 4.12, RC 1.14.2 

Steps to Reproduce

• ...

Expected Results

• ...

Actual Results

• ...

Problem Analysis

• <Completed by engineering team as part of the triage/refinement process>

Root Cause

• <What is the root cause of the problem? Or, why is it not a bug?>

Workaround (If Possible)

• <Are there any workarounds we can provide to the customers?>

Fix Approaches

• <If we decide to fix this bug, how will we do it?>

Acceptance Criteria

• ...

Definition of Done

• Code Complete:
  • All code has been written, reviewed, and approved.
• Tested:
  • Unit tests have been written and passed.
  • Ensure code coverage is not reduced with the changes.
  • Integration tests have been automated.
  • System tests have been conducted, and all critical bugs have been fixed.
  • Tested and merged on OpenShift either upstream or downstream on a local build.
• Documentation:
  • User documentation or release notes have been written (if applicable).
• Build:
  • Code has been successfully built and integrated into the main repository / project.
  • Midstream changes (if applicable) are done, reviewed, approved and merged.
• Review:
  • Code has been peer-reviewed and meets coding standards.
  • All acceptance criteria defined in the user story have been met.
  • Tested by reviewer on OpenShift.
• Deployment:
  • The feature has been deployed on OpenShift cluster for testing.