Uploaded image for project: 'OpenShift GitOps'
  1. OpenShift GitOps
  2. GITOPS-5877

Log Create/Update/Deletion actions performed by Argo CD operator

XMLWordPrintable

    • Log Create/Update/Deletion actions performed by Argo CD operator
    • False
    • None
    • False
    • To Do
    • 100% To Do, 0% In Progress, 0% Done

      Epic Goal

      At present (in most cases), Argo CD operator doesn't log when it is creating/deleting/modifying resources in a namespace, or at cluster-scope.

      Just to pick a random example, when Argo CD ApplicationSet Roles are reconciled, all that is printed is `log.Info("reconciling applicationset roles")`. There is no log for the creation/modification/deletion of the actual Role object (https://github.com/argoproj-labs/argocd-operator/blob/c658393241a52d4f9344beae2db6d4aa89bec3d7/controllers/argocd/applicationset.go#L734).

      This makes it challenging to know what actions the operator is taking, especially when, e.g. looking at customer logs from a must gather.

      We can add log statements to argocd-operator to log non-trivial actions:

      • Creation of a K8s resource: e.g. `log.Info("Creating Argo CD RBAC ConfigMap")`
      • Deletion of a K8s resource, e.g. `log.Info("Deleting ConfigMap since HA enabled flag is false")`
      • Update of .spec/.metadata field, e.g. `log.Info("Removing 'argocd.argoproj.io/managed-by' from (resource name")`
        • We should NOT log updates to .status field

              jgwest Jonathan West
              jgwest Jonathan West
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated: