-
Story
-
Resolution: Done
-
Major
-
None
-
None
-
None
-
5
-
False
-
None
-
False
-
SECFLOWOTL-195 - RFEs 1.15
-
-
-
3
-
GitOps Crimson - Sprint 3263, GitOps Crimson - Sprint 3264, GitOps Crimson - Sprint 3265
Story (Required)
As a Argo CD admin if I configure tls certs for Argo CD server route by directly embedding tls data into ArgoCD CR, I should get warning messages about deprecation in logs.
Background (Required)
Directly embedding tls data into ArgoCD CR is deprecated in favor of new way to configure tls data using secrets
Approach (Required)
- When .spec.server.route.tls.certificate or .spec.server.route.tls.key fields are used in ArgoCD CR log
- warning message in operator logs
- emit a kubernetes event (if possible )
- Need update here: https://github.com/argoproj-labs/argocd-operator/blob/2ef2bc4ab6e9884aede06c62618968778346ce90/controllers/argocd/route.go#L478-L482
Some references
- https://github.com/argoproj-labs/argocd-operator/pull/1192
- https://github.com/argoproj-labs/argocd-operator/pull/797
Test instructions: https://github.com/argoproj-labs/argocd-operator/pull/1547
Acceptance Criteria (Mandatory)
- Whenever deprecated fields _.spec.server.route.tls.certificate or .spec.server.route.tls.key are used, user should be notified via warning messages about deprecation and the new method to configure tls data._
INVEST Checklist
Dependencies identified
Blockers noted and expected delivery timelines set
Design is implementable
Acceptance criteria agreed upon
Story estimated
Legend
Unknown
Verified
Unsatisfied
Done Checklist
- Code is completed, reviewed, documented and checked in
- Unit and integration test automation have been delivered and running cleanly in continuous integration/staging/canary environment
- Continuous Delivery pipeline(s) is able to proceed with new code included
- Customer facing documentation, API docs etc. are produced/updated, reviewed and published
- Acceptance criteria are met