Story (Required)

Currently, we are missing the functionality to add extra command args for application controller deployment in operator. It is supported for other Argo CD deployment like repo-server, applicationset-controller, argocd-server via extraCommandArgs field in ArgoCD CRD.

https://argocd-operator.readthedocs.io/en/latest/reference/argocd/#controller-options 

https://argocd-operator.readthedocs.io/en/latest/reference/argocd/#applicationset-controller-options 

https://argocd-operator.readthedocs.io/en/latest/reference/argocd/#server-options 

Background (Required)

This limitation was encountered  while working on a customer case. There was a requirement to set --repo-error-grace-period-seconds flag however due to missing functionality it was not possible to set it directly. A workaround that unblocked the customer was to use .spec.controller.env to set the required flag via env var which in this case was ARGOCD_REPO_ERROR_GRACE_PERIOD_SECONDS.

Approach (Required)

Introduce a new `extraCommandArgs` feild in ArgoCD CRD under `.spec.conrtoller`. Use argocd-server or repo-server code as reference

Acceptance Criteria (Mandatory)

<Describe edge cases to consider when implementing the story and defining tests>

<Provides a required and minimum list of acceptance tests for this story. More is expected as the engineer implements this story>

INVEST Checklist

Dependencies identified

Blockers noted and expected delivery timelines set

Design is implementable

Acceptance criteria agreed upon

Story estimated

Legend

Unknown

Verified

Unsatisfied

Done Checklist

• Code is completed, reviewed, documented and checked in
• Unit and integration test automation have been delivered and running cleanly in continuous integration/staging/canary environment
• Continuous Delivery pipeline(s) is able to proceed with new code included
• Customer facing documentation, API docs etc. are produced/updated, reviewed and published
• Acceptance criteria are met