Uploaded image for project: 'OpenShift GitOps'
  1. OpenShift GitOps
  2. GITOPS-3041

Remove deprecated .spec.resourceCustomizations from ArgoCD v1beta1 CRD

XMLWordPrintable

    • 3
    • False
    • None
    • False
    • Hide
      With this update, `.spec.resourceCustomizations` field has been removed from ArgoCD CRD. Bug fixes and support are provided only through the end of the gitops-operator v1.9 lifecycle. As an alternative to `.spec.resourceCustomizations`, you can use `.spec.resourceHealthChecks`, `.spec.resourceIgnoreDifferences`, and `.spec.resourceActions` fields instead.

      !!!important
      Breaking change: With this update, the `.spec.resourceCustomizations` field has been removed from ArgoCD CRD. To prevent data loss during upgrade to gitops-operator v1.10, ensure that you backup `.spec.resourceCustomization` value if it is used in your ArgoCD CRs.
      Show
      With this update, `.spec.resourceCustomizations` field has been removed from ArgoCD CRD. Bug fixes and support are provided only through the end of the gitops-operator v1.9 lifecycle. As an alternative to `.spec.resourceCustomizations`, you can use `.spec.resourceHealthChecks`, `.spec.resourceIgnoreDifferences`, and `.spec.resourceActions` fields instead. !!!important Breaking change: With this update, the `.spec.resourceCustomizations` field has been removed from ArgoCD CRD. To prevent data loss during upgrade to gitops-operator v1.10, ensure that you backup `.spec.resourceCustomization` value if it is used in your ArgoCD CRs.
    • Removed Functionality
    • GITOPS Sprint 3244

      Story (Required)

      Drop support for deprecated `.spec.resourceCustomizations` field in ArgoCD v1beta1 CRD in favour of spec.ResourceHealthChecks, spec.ResourceIgnoreDifferences, and spec.ResourceActions 

      Background (Required)

      In GITOPS-2890, we informed users about removal of `.spec.resourceCustomizations` field in upcoming gitops-operator v1.10 release. Since this is a break change, we should get it out in v1.10 as we will be upgrading crd api version to v1beta1 in v1.10 release.  

      Approach (Required)

      • Remove `.spec.resourceCustomizations` from ArgoCD v1beta1 CRD
      • Remove backward compatible logic added in https://github.com/argoproj-labs/argocd-operator/pull/793 
      • Add conversion logic to migrate `.spec.resourceCustomizations` in v1alpha1 to equivalent fields  spec.ResourceHealthChecks, spec.ResourceIgnoreDifferences, and spec.ResourceActions  in v1beta1 (Not required since users were informed well in advance)

      Acceptance Criteria (Mandatory)

      • .spec.resourceCustomizations field is removed in ArgoCD v1beta1 CRD
      • unit & e2e tests are added
      • documentation is updated

      Done Checklist

      • Code is completed, reviewed, documented and checked in
      • Unit and integration test automation have been delivered and running cleanly in continuous integration/staging/canary environment
      • Continuous Delivery pipeline(s) is able to proceed with new code included
      • Customer facing documentation, API docs etc. are produced/updated, reviewed and published
      • Acceptance criteria are met

              rh-ee-sghadi Siddhesh Ghadi
              rh-ee-sghadi Siddhesh Ghadi
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: