Description of problem:
Currently if someone wishes to enable server autoscaling by setting `.spec.server.autoscale.enabled` to "true" and specifies further HPA settings in `.spec.server.autoscale.hpa`, the operator creates an HPA with said settings on the cluster. However, upon updating these settings in the CR field, the changes are not propogated to the created HPA object. Thus, the new HPA parameters are ignored and autoscaling is not fully respected
Prerequisites (if any, like setup, operators/versions):
Steps to Reproduce
- Deploy the operator and create an argocd instance
- enable server autoscaling using the following config:
spec:
server:
autoscale:
enabled: true
hpa:
minReplicas: 1
maxReplicas: 3
targetCPUUtilizationPercentage: 50
scaleTargetRef:
kind: Deployment
apiVersion: apps/v1
name: argocd-server
- confirm that HPA object is created with provided configuration and server deployment is appropriately scaled by HPA
- update hpa settings in `.spec.server.autoscale.hpa`
Actual results:
observe that hpa resource on cluster is not updated and server deployment is not scaled accordingly **
Expected results:
cluster hpa resource should be updated and deployment scaled according to new parameters
Reproducibility (Always/Intermittent/Only Once):
always
Acceptance criteria:
Updated HPA parameters should be honored and propogated
Definition of Done:
fix is released
Build Details:
Additional info (Such as Logs, Screenshots, etc):