Uploaded image for project: 'OpenShift GitOps'
  1. OpenShift GitOps
  2. GITOPS-2793

CI should fail on operators when bundle manifests are changed directly

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Unresolved
    • Icon: Undefined Undefined
    • None
    • 1.8.1
    • Operator
    • None
    • 3
    • False
    • None
    • False

      Story (Required)

      The `bundle` folder of the operator contains the manifests that are used to deploy the operator through OLM. These files should not be updated directly but they should be generated by the `make bundle` target.

      `make bundle` looks for any new changes in `config` folder and generates the bundle manifests. So it is responsibility of the developer to update the `config` folder and then run `make bundle`

      However, there are cases, where we updated the bundle folder directly. This will result in changes being removed when next time some one runs `make bundle`.

      Background (Required)

      Out of scope

      Changes to the operator code

      Approach (Required)

      Use `github-actions` to run `make bundle` on the CI and verify the PR is adding any unwanted changes to the operator.

      Dependencies

      <Describes what this story depends on. Dependent Stories and EPICs should be linked to the story.>

      Acceptance Criteria (Mandatory)

      1. GitHub Actions CI to verify the PR does not include any unwanted bundle manifest changes.
      2. CI should fail on the PR if there are any unwanted changes.

      INVEST Checklist

      Dependencies identified

      Blockers noted and expected delivery timelines set

      Design is implementable

      Acceptance criteria agreed upon

      Story estimated

      Legend

      Unknown

      Verified

      Unsatisfied

      Done Checklist

      • Code is completed, reviewed, documented and checked in
      • Unit and integration test automation have been delivered and running cleanly in continuous integration/staging/canary environment
      • Continuous Delivery pipeline(s) is able to proceed with new code included
      • Customer facing documentation, API docs etc. are produced/updated, reviewed and published
      • Acceptance criteria are met

            Unassigned Unassigned
            aveerama@redhat.com Abhishek Veeramalla
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: