Uploaded image for project: 'OpenShift GitOps'
  1. OpenShift GitOps
  2. GITOPS-2651

Change Appset deletion behavior when --policy create-only is set

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Won't Do
    • Icon: Normal Normal
    • None
    • None
    • ArgoCD
    • None
    • 5
    • False
    • Hide

      None

      Show
      None
    • False

      Story (Required)

      As a user of appset trying to delete an applicationset when 'create-only' policy is in place, I want the managed applications to not get deleted

      Background (Required)

      Currently there seems to be a bug in Argo CD. When applicationset-controller is supplied with `–policy create-only` command, appset can only create applications, and not do any further modifications to them or delete them. However, if you were to delete the applicaitonset resource the child applications get deleted anyway. 

       

      _see https://github.com/argoproj/argo-cd/issues/12172_

      Out of scope

       

      Approach (Required)

      Reproduce issue locally
      if successfully reproduced, refine controller logic to react to finalizer placed on appset - on appset deletion controller should remove owner references from all child apps before appset is deleted 

      Dependencies

      none

      Acceptance Criteria (Mandatory)

      when appset-controller has `–policy create-only` specified, users should be able to delete appset without having the child applications deleted as well 

      INVEST Checklist

      Dependencies identified

      Blockers noted and expected delivery timelines set

      Design is implementable

      Acceptance criteria agreed upon

      Story estimated

      Legend

      Unknown

      Verified

      Unsatisfied

      Done Checklist

      • Code is completed, reviewed, documented and checked in
      • Unit and integration test automation have been delivered and running cleanly in continuous integration/staging/canary environment
      • Continuous Delivery pipeline(s) is able to proceed with new code included
      • Customer facing documentation, API docs etc. are produced/updated, reviewed and published
      • Acceptance criteria are met

              jrao@redhat.com Jaideep Rao
              jrao@redhat.com Jaideep Rao
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: