Problem

As an Argo CD user trying to manage application deployments with sync waves, I want Argo CD to wait for resources to be completely deleted before moving on to the next sync wave during the deletion process.

This improvement ensures that Argo CD properly manages resource deletion in a controlled and predictable manner, enhancing the user experience and preventing potential issues caused by not waiting for resources to be fully recycled before moving on to the next sync wave.

Upstream Issue: https://github.com/argoproj/argo-cd/issues/12376

Background

Users have reported that when using sync waves to manage application deployments, Argo CD does not wait for resources to be completely deleted before moving on to the next sync wave. Instead, Argo CD only sets the DeletionTimestamp and proceeds to the next wave, potentially causing issues in certain scenarios.

Out of scope

• Changes to sync wave creation or deployment processes
• Modifications to other aspects of the Argo CD resource lifecycle

Approach

1. Investigate the current implementation of the Argo CD sync wave deletion process.
2. Identify the code responsible for proceeding to the next sync wave without waiting for the resources to be completely deleted.
3. Modify the implementation to ensure Argo CD waits for resources to be fully deleted before moving on to the next sync wave.
4. Write a unit test to verify the new behavior and ensure the bug is fixed.

Dependencies

• Familiarity with the Argo CD codebase and sync wave implementation.
• Familiarity with the sync wave workflow as an ArgoCD administrator.
• https://issues.redhat.com/browse/GITOPS-2802 has to be implemented first!

Acceptance Criteria

• Argo CD waits for resources in sync wave X to be fully deleted before moving on to sync wave X-1.
• Unit test written to verify the new behavior and confirm the bug fix.
• No regression in existing Argo CD functionality.

Done Checklist

• Code changes implemented and tested
• Unit test written and passing
• Documentation updated if necessary
• PR submitted and reviewed
• Changes merged into the main branch