-
Bug
-
Resolution: Done
-
Major
-
1.6.0
-
False
-
None
-
False
-
There is an issue with the health check for subscription object in ArgoCD.
A project can have max 5 InstallPlan objects. Whenever more than 5 operators are installed in a project, the oldest InstallPlan gets deleted. This is the default behaviour.
Now if the operators are managed in ArgoCD as apps, the operator whose subscription has 'InstallPlanMissing' condition true is marked degraded which shouldn't always be the case. The operator works fine and just the InstallPlan being missing doesn't affect it's functionality. Also it shows all good on the Installed Operators page. Hence it shouldn't be marked degraded in GitOps just because InstallPlan is missing.
The health check conditions need changes.
[GITOPS-2018] Subscription health check marks it degraded for InstallPlanMissing condition being true even if the operator has no issues
| Workflow | Original: OJA-WF-AM [ 18455090 ] | New: OJA-WF-E [ 23322236 ] |
| Sprint |
| Rank | New: Ranked higher |
| Sprint | New: GITOPS Sprint 235 [ 50314 ] |
| Sprint |
| Labels | Original: release-note-item | New: release-note-item rn-done-resolved |
| Remote Link |
New:
This issue links to "openshift/openshift-docs#52437: |
| Release Note Text | New: Before this fix, Subscription health check was marked degraded for missing InstallPlan when more than 5 operators are installed in a project. With this fix, Subscription health check will not be marked as degraded for missing InstallPlan if more than 5 operators are installed in a project. |
| Labels | New: release-note-item |
| Affects Version/s | New: 1.6.0 [ 12358778 ] |
| Fix Version/s | New: 1.6.2 [ 12393407 ] |
| Resolution | New: Done [ 1 ] | |
| Status | Original: To Do [ 10020 ] | New: Closed [ 6 ] |
Hi rhn-support-alosingh , We'll cherry-pick the fix into upstream with Argo CD 2.4.12 (next patch release)
Hi isequeir@redhat.com, Please provide an update on this. The mentioned PR seems to be merged.
PR has been raised with this fix in ArgoCD
https://github.com/argoproj/argo-cd/pull/10450
| Assignee | New: Ishita Sequeira [ isequeir@redhat.com ] |
gnunn@redhat.com Thanks for sharing the solution. The solution makes sense.
I will create a PR for this with the fix.
| Rank | New: Ranked lower |
| Sprint | Original: GITOPS Sprint 222 [ 45500 ] | New: Backlog - Argo CD [ 38826 ] |
I think the solution to this is to modify the health to dig a little deeper, I'm using the following in my health check:
elseif (condition.type == "InstallPlanMissing" and condition.reason ~= "ReferencedInstallPlanNotFound") then
See here for full health check I'm using:
| Status | Original: New [ 10016 ] | New: To Do [ 10020 ] |
| Sprint | Original: Backlog - Argo CD [ 38826 ] | New: GITOPS Sprint 222 [ 45500 ] |
| Priority | Original: Critical [ 2 ] | New: Major [ 3 ] |
| Sprint | New: Backlog - Argo CD [ 38826 ] |
It's not an issue with the OLM. It's an expected beahviour to have 5 InstallPlans per namespace. This is to avoid unnecessary high number of InstallPlans in the cluster. It was discussed here - https://coreos.slack.com/archives/C3VS0LV41/p1648839289175399.
I opened this bug as per the conversation here - https://coreos.slack.com/archives/CMP95ST2N/p1652123107943939.
| Component/s | New: ArgoCD [ 12335853 ] |
| Summary | Original: Subscription heath check marks it degraded for InstallPlanMissing condition being true even if the operator has no issues | New: Subscription health check marks it degraded for InstallPlanMissing condition being true even if the operator has no issues |
rhn-support-alosingh this would be a part of 1.6.2