-
Epic
-
Resolution: Done
-
Major
-
None
-
Merge ApplicationSet into Argo CD installation
-
False
-
False
-
Done
-
0% To Do, 0% In Progress, 100% Done
-
Upstream Story: https://github.com/argoproj/argo-cd/issues/7351
Summary
The applicationset was created with the intention to merge it into Argo CD eventually. The project had been validated and mature enough. It should be available out of the box with Argo CD. In order to improve user experience, the ApplicationSet controller should be available in Argo CD out of the box.
Proposal
The https://github.com/argoproj-labs/applicationset repository should be moved into https://github.com/argoproj org. The Argo CD controller should
have applicationset controller as a separate process/pod. The Argo CD installation manifests should include application set manifests
Probable steps:
We want to go the route of maintaining ApplicationSet controller as a standalone Deployment. We will start this effort base on ApplicationSet 0.3.0.
- Review/merge/close remaining PRs https://github.com/argoproj-labs/applicationset/pulls
- Add note docs in old repo about the archiving
- Move applicationset repo from 'argoproj-labs' to 'argoproj' org
- One of the argoproj admins would need to do this.
- Update references in the code from github.com/argoproj-labs/applicationset to github.com/argoproj/applicationset
- GitHub should transparently redirect until we complete this refactor
- Then run the existing tests and make sure they still pass .
- manifests/cluster-install/kustomization.yaml and manifests/namespace-install/kuztomization.yaml should be updated to reference the ApplicationSet install YAML.
- For an example of this, see how we are doing this in the reverse direction with the ApplicationSet controller install.
- Are there any other kustomization.yaml files that we need to update? What about the manifests/ha folder?
- Update the Argo CD docs to indicate that ApplicationSet controller is now bundled.
- Update the ApplicationSet docs to remove the install instructions (or at least, to indicate that install is no longer required, once Argo CD v2.3 is released)
- Add the ApplicationSet E2E tests to GitHub actions (not stricly necessary since we are testing in the reverse direction from appset project, but can't hurt)
- Review/move remaining 74 issues to argocd https://github.com/argoproj-labs/applicationset/issues
Acceptance Criteria
- ApplicationSet source and repository is moved to argocd-proj which also means that all references to github.com/argoproj-labs/applicationset are changed to github.com/argoproj/applicationset
- Update manifests (installations) to include applicationset deployments in cluster and namespaced installations
- Update docs to reflect the changes
- blocks
-
GITOPS-1653 Update ArgoCD & GitOps Operators after ApplicationSet merged to ArgoCD
- Closed