Uploaded image for project: 'Fuse/AMQ Documentation'
  1. Fuse/AMQ Documentation
  2. FUSEDOC-866

CXF Development Guide PART V issues

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 6.2.0
    • 6.2.0
    • None
    • None

      1) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSServiceDevJavaFirstSEI.html#JAXWSServiceDevJavaFirstSEIExample010
      https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSServiceDevJavaFirstSEI.html#JAXWSServiceDevJavaFirstSEIExample020
      The examples (as well as some other examples in the guide) dont't follow Java naming convention - a first letter in uppercase for a type name (quoteReporter/stockQuoteReporter). Note that these types are used in a number of examples. The identifiers to rename have to be carefully checked, because there are cases where lower case first latter is correct (a variable name). I don't see breaking of the convention as a big issue. So, if you consider that it might cause inconsistency with possibly existing real examples or bring inconsistency by forgotting to rename some identifiers, feel free to skip this.

      2) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html-single/Apache_CXF_Development_Guide/index.html#JAXWSWSDLDevExample010
      I don't see any funcitonal difference between syHi and greetMe operations. siHi probably shoudn't have an input parameter.

      3) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSServiceDevWSDLFisrtGenCode.html#JAXWSServiceDevCodeGenTable010
      Format of left column items is not unified.

      4) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSConsumerDevWSDLFirst.html
      "One way method of creating a consumer ..." is incorrect. "One way of creating a consumer" would be better.

      5) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSWSDLBootstrap.html#topic-40481

      • "using hard coded paths does not translate to enterprise deployments." It would be better to use "fit" instead of "translate"
      • the last item of the list is just "the". Likely it should be "A contact resolver".
      • "Injecting the proxy into your implementation code is generally the best option". Maybe it would be good to explain why is it so.

      6) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSProxyInjection.html
      "The implementation is handed a reference to the instantiated proxy". Should be "handed by a reference"

      7) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSProxyInjection.html#JAXWSProxyInjectionConfigEx
      "If books.wsdl in on the classpath". Should be "If books.wsdl is on the classpath".

      8) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSWSDLBootstrapResolver.html#JAXWSWSDLBootstrapResolverEx010
      "You can add logic that to resolve contract locations from a UDDI registry". Should be "that resolves contract locations"

      9) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSFaults.html
      "The JAX-WS specification defines two type of faults". Should be "two types of faults"

      10) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSFaultsProtocol.html#JAXWSFaultsProtocolTypesTbl
      Formatting of javax.xml.ws.http.HTTPException differs from other exceptions in the table.

      11) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSDataMappingOverview.html#JAXWSDataOverviewImportEx010

      • IMO the example is not valid: <element name="includedSeq" type="tns:IncludedSequence"/>. The type attribute contains tns prefix, but the namespace of IncludedSequence is http://schemas.redhat.com/tests/imported_types. It can be fixed by adding of the namespace to the definitions element of importing document.
      • Also notice that the names of example 31.3 and 31.4 are not accurate - Includes/Imports and Included/Imported.

      12) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSDataObjectFactory.html
      https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSDataMappingOverMoreClasses.html
      https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSElementMapping.html
      https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSCustomTypeMappingJavaType.html#JAXWSCustomTypeMappingJavaTypeGlobalGenEx
      Wrong formatting of Java code examples. Mainly of annotations. Also note a surplus space in Adapter1 .class In the last example in the last example.

      13) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSCustomTypeMappingJavaType.html#JAXWSCustomTypeMappingJavaTypeConvertImpl
      Remove "has" from "The Apache CXF runtime has does not know how to convert XML primitive types".

      14) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSCustomTypeMappingBase.html#JAXWSCustomBasePlainEx010
      Missing quote in "Address.

      15) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSAsyncDev.html
      https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSAsyncDevCodeGen.html#idp19608000
      An extra newline in list items. "Polling approach" and "Callback approach".

      16) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSAsyncDevException.html
      Remove "than" from "Consumers making asynchronous requests will not receive the same exceptions returned than when they make synchronous requests."

      17) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSAsyncDevException.html
      "the Response<T> object's get() method does not throw either user modeled exceptions nor the generic JAX-WS exceptions". I think that either and nor don't fit together. Better is "... method throws neither user modeled exceptions nor the generic JAX-WS exceptions".

      18) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSContextsConsumer.html
      "The request context enables ..." is highlighted

      19) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSContextsConsumer.html#JAXWSContextsConsumerExample010
      The examples' label as well as the text above the example "obtaining the request context" are about the request context, but actually the response context is used in the example.

      20) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSContextsConsumer.html#topic-40577
      Different formatting for org.apache.cxf.ws.addressing.JAXWSAConstants and org.apache.cxf.transports.jms.context.JMSConstants than javax.xml.ws.BindingProvider.

      21) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSDevContextsJMSMessageProperties.html#CXFJMSGetConsumerResponseHeaderExample010
      Instead of responseContext.get(JMSConstants.JMS_CLIENT_REQUEST_HEADERS); should be responseContext.get(JMSConstants.JMS_CLIENT_RESPONSE_HEADERS);.

      22) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSDevContextsJMSMessageProperties.html#topic-40027

      • The sentence "In addition, you can see how long the client waits for a response before timing out." is IMO taken a bit out of the context. Does it refer to JMS_CLIENT_RECEIVE_TIMEOUT mentioned further or something else? I am not sure if the property is even implicitly set, so a user cannot see it.
      • "You can To get the JMS message headers from a consumer's response context do the following:" should be "To get the JMS message headers from a consumer's response context, do the following:". Not sure about placing the comma behind context.
      • "header properties" is used several times in the section, this term is a bit confusing. In context of JMS, headers are predefined/standard metadata while properties are user defined metadata. It should be clearly and unchangeable used in the section.

      23) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSHandlers.html#topic-40514
      "Logical handlers can process ..." is highlighted

      24) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSSOAPHandlersMessage.html
      "The handleMessage() method receives a SOAPMessageHandler object" should be replaced by "The handleMessage() method receives a SOAPMessageContext object"

      25) https://access.redhat.com/documentation/en-US/Red_Hat_JBoss_Fuse/6.2/html/Apache_CXF_Development_Guide/JAXWSHandlersConfig.html#topic-40247
      Add space between "JSR 109" and "(Web Services for Java EE, Version 1.2)"

              jmurphey_jira Jane Murphey (Inactive)
              trohovsky Tomas Rohovsky (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved:

                  Estimated:
                  Original Estimate - 3 days
                  3d
                  Remaining:
                  Time Spent - 1 day, 3 hours, 30 minutes Remaining Estimate - 1 day, 4 hours, 30 minutes
                  1d 4h 30m
                  Logged:
                  Time Spent - 1 day, 3 hours, 30 minutes Remaining Estimate - 1 day, 4 hours, 30 minutes
                  1d 3h 30m