Uploaded image for project: 'Forge'
  1. Forge
  2. FORGE-373

remove-plugin is always successful (it "lies")

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 1.0.0.Beta4
    • 1.0.0.Beta3
    • Plugin API
    • None

      The wrong way:

      [no project] git $ forge list-plugins 
      com.redhat.openshift.express.openshift-express-plugin:1.0.0-SNAPSHOT-155e7864-17ee-434f-9d00-1d3a97daceb0
      org.richfaces.forge.richfaces-forge-plugin:1.0.0-SNAPSHOT-943ecca1-e619-4fa8-8559-5ab834c91c29
      [no project] git $ forge remove-plugin richfaces
      ***INFO*** Preparing to remove plugin: richfaces
      Warning:  The encoding 'UTF-8' is not supported by the Java runtime.
      ***SUCCESS*** Successfully removed [richfaces]
      [no project] git $ forge list-plugins 
      com.redhat.openshift.express.openshift-express-plugin:1.0.0-SNAPSHOT-155e7864-17ee-434f-9d00-1d3a97daceb0
      org.richfaces.forge.richfaces-forge-plugin:1.0.0-SNAPSHOT-943ecca1-e619-4fa8-8559-5ab834c91c29
      

      Removing a non-existing plugin ... successful ???

      [no project] git $ forge remove-plugin richfacesx
      ***INFO*** Preparing to remove plugin: richfacesx
      Warning:  The encoding 'UTF-8' is not supported by the Java runtime.
      ***SUCCESS*** Successfully removed [richfacesx]
      

      The right way:

      [no project] git $ forge remove-plugin org.richfaces.forge.richfaces-forge-plugin
      ***INFO*** Preparing to remove plugin: org.richfaces.forge.richfaces-forge-plugin
      Warning:  The encoding 'UTF-8' is not supported by the Java runtime.
      ***SUCCESS*** Successfully removed [org.richfaces.forge.richfaces-forge-plugin]
      [no project] git $ forge list-plugins 
      com.redhat.openshift.express.openshift-express-plugin:1.0.0-SNAPSHOT-155e7864-17ee-434f-9d00-1d3a97daceb0
      

      Forge should display error if plugin name is not found / invalid.

      Even better yet, provide TAB completion what plugin names are remove-able. (just like sudo aptitude remove <TAB> works in Ubuntu...)

            lincolnthree Lincoln Baxter III (Inactive)
            HendyIrawan Hendy Irawan (Inactive)
            Votes:
            1 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: