Uploaded image for project: 'Forge'
  1. Forge
  2. FORGE-1926 Adding more commands to Forge and improve existing ones
  3. FORGE-2369

In commands there are several targetXXX attributes, some are confusing


    • Icon: Sub-task Sub-task
    • Resolution: Unresolved
    • Icon: Major Major
    • 3.x Future
    • 2.16.2.Final
    • UI - API
    • None

      At the moment commands deal with different targetXXX attributes. Some are easy to understand but some are confusing. We have :

      • targetClass : this mostly targets a Java class
      • targetDirectory : used in GitCloneCommand, for example, but also in NewEJBCommand or FacesNewBean (which relate to Java code and should then be targetPackage)
      • targetEJB : used in EJBSetClassTransactionAttributeCommand, it should just be targetClass that filter EJBs
      • targetEntity : used in JPANewFieldWizard or JPANewNamedQueryCommand, it should just be targetClass that filter Entities
      • targetFolder : used in CopyCommand and MoveCommand but is fine like that because this parameter is not visible to the user
      • targetLocation : is mostly used when a project doesn't exist, but it is also used in JPANewEntityCommand
      • targetPackage : for a Java class
      • targetResource : used in CopyCommand and MoveCommand but it's not visible for the user
      • targetSuperClass : used in JavaNewMethodCommand to target the super class, as there is already a targetClass attribute, but it should maybe be type
      • targetTypes : used in CDINewStereotype command, it should be types like most commands

            Unassigned Unassigned
            agoncal Antonio Goncalves (Inactive)
            0 Vote for this issue
            1 Start watching this issue