Uploaded image for project: 'Forge'
  1. Forge
  2. FORGE-1813

Shall we rename webroot to targetDir or something different ?

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Won't Do
    • Icon: Major Major
    • 2.x Future
    • 2.5.0.Final
    • Brainstorming
    • None

      In FORGE-1787 the parameter webroot seems confusing. Maybe we could change it to targetDir like other command, or something different (as it refer to a subdirectory of web app.

      Read on #IRC

      agoncal  And what about targetPackage ? What I really want is a --webroot (like the scaffold command) no ?
      lincolnthree  agoncal: targetDir ?
      agoncal  lincolnthree Hum... it's called --webroot on other places (which is the relative webapp/ directory)
      lincolnthree  agoncal: but it's not the webroot dir in this case
      lincolnthree  agoncal: it's the target directory where the file will be generated
      gastaldi  +1 to targetDir
      lincolnthree  agoncal: doesn't have to be in the web root, but could default there
      lincolnthree  or even just target
      agoncal  lincolnthree But by default it's under /webapp if you don't specify it. If you do (eg. --webroot admin) then the file is generated under /webapp/admin
      agoncal  I'm refering to webroot because it looks the same as FORGE-1787
      lincolnthree  agoncal: totally different
      agoncal  lincolnthree ok
      lincolnthree  agoncal: well.. maybe not totally :p
      lincolnthree  agoncal: webroot is a bad name for that
      agoncal  lincolnthree I'll go for for targetDir
      agoncal  lincolnthree Do you want me to create a JIRA about renaming webroot to targetDir ?
      lincolnthree  agoncal: why not skip targetDir entirely and just go for —output
      lincolnthree  agoncal: yeah we may want to address this
      lincolnthree  output would be target dir and filename together
      

              Unassigned Unassigned
              agoncal Antonio Goncalves (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: