Uploaded image for project: 'FlightPath'
  1. FlightPath
  2. FLPATH-1584

[Tracker] Template review page should not invent the parameter names

XMLWordPrintable

    • Icon: Story Story
    • Resolution: Done
    • Icon: Undefined Undefined
    • None
    • None
    • orchestrator-ui
    • None
    • False
    • Hide

      None

      Show
      None
    • False

      This issue was created to track https://github.com/backstage/backstage/issues/23794 that got closed due to inactivity. 

      The issue is still valid. Here is the copy of its description:

      📜 Description

      When you create a software template and provide some input parameters, the Review page shows a summary table of the provided inputs with a left column that is not reflecting the parameter labels displayed in the previous pages.

      FYI @masayag @pkliczewski @gciavarrini

      👍 Expected behavior

      The parameter name in the Review page should be the same as the one in the configuration screen.

      👎 Actual Behavior with Screenshots

      E.g., if we define an input parameter as:
      argocdNamespace: title: ArgoCD Namespacetype: string
       
      the configuration screen displays the proper label from the parameter title as ArgoCD Namespace, while the Review page, for the same parameter, displays Argocd Namespace.
      Our guess is that this page is trying to apply a heuristic to compute a human readable label, by adding a space before any uppercase character in the property name argocdNamespace, and always capitalize the first letter.
      Anyway, whatever the transformation logic adopted here, the question is why this page is not using the original labels instead.

      👟 Reproduction steps

      Create a template having some input parameters and compare the labels in the Review screens against those in the previous pages.

            brotman@redhat.com Bat-Zion Rotman
            masayag@redhat.com Moti Asayag
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: