Uploaded image for project: 'FlightPath'
  1. FlightPath
  2. FLPATH-1556

setup.sh script prompts users if NOTIFICATIONS_* variables are not set

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Undefined Undefined
    • None
    • None
    • None
    • False
    • Hide

      None

      Show
      None
    • False
    • Moderate

      Description of the problem:

      A recent change introduced notification email setup into the setup.sh script. Previously the script would run non-interactively if a few required variables were set and --set-defaults flag was used. With the email notification change, the following variables must be set or the script goes interactive, prompting the user for values.

      NOTIFICATIONS_EMAIL_HOSTNAME=
      NOTIFICATIONS_EMAIL_USERNAME=
      NOTIFICATIONS_EMAIL_PASSWORD=

      Although I understand this is using defaults, it would be preferable to be able to set a variable to skip this setup, such as SETUP_NOTIFICATIONS_EMAIL=false

      How reproducible: 100%

      Steps to reproduce:

      1. Run script without setting any NOTIFICATIONS_* vars and use defaults
      export KUBECONFIG=/home/kni/clusterconfigs/auth/kubeconfig
      export GITHUB_TOKEN=fwfewf
      export GITHUB_CLIENT_ID=asdsa
      export GITHUB_CLIENT_SECRET=asd
       ./setup.sh --use-default

      Actual results:

      Script will go interactive, prompting the user to fill in the values

      Expected results:

      Script remains non-interactive or there is a variable to skip the setup all together

            masayag@redhat.com Moti Asayag
            chadcrum Chad Crum
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: