Uploaded image for project: 'Fast Datapath Product'
  1. Fast Datapath Product
  2. FDP-793

[ovs bond]create bond port failed but return code is 0

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Normal Normal
    • None
    • None
    • None
    • 3
    • False
    • Hide

      None

      Show
      None
    • False
    • Hide

      Given that an ovs-vsctl add-bond command fails to attach devices properly, 

      When the bond creation operation fails internally,

      Then ovs-vsctl must return a non-zero exit status to signal the failure immediately at CLI level.

      Show
      Given that an ovs-vsctl add-bond command fails to attach devices properly,  When the bond creation operation fails internally, Then ovs-vsctl must return a non-zero exit status to signal the failure immediately at CLI level.
    • openvswitch3.6-3.6.0-0.2.el9fdp
    • rhel-9
    • None
    • rhel-net-ovs-dpdk
    • ssg_networking
    • OVS/DPDK - FDP-25.E - 2, FDP-OVS/DPDK Sprint 7, FDP-OVS/DPDK Sprint 8, OVS/DPDK - Sprint 9 - East, OVS/DPDK - Sprint 10 - East
    • 5

      Description of problem:
      when create a ovs bond port failed, check the return code of the create command is 0.

      Version-Release number of selected component (if applicable):
      kernel version:5.14.0-277.el9.x86_64
      openvswitch version:
      openvswitch-selinux-extra-policy-1.0-31.el9fdp.noarch
      openvswitch3.1-3.1.0-2.el9fdp.x86_64
      python3-openvswitch3.1-3.1.0-2.el9fdp.x86_64
      openvswitch3.1-test-3.1.0-2.el9fdp.noarch

      How reproducible: 100%

      Steps to Reproduce:
      1. run below script
      rmmod vfio_iommu_type1
      rmmod vfio_pci
      rmmod vfio_pci_core
      systemctl restart openvswitch
      ovs-appctl vlog/set console:lacp:dbg syslog:lacp:dbg file:lacp:dbg
      ovs-appctl vlog/set console:bond:dbg syslog:bond:dbg file:bond:dbg
      ovs-appctl vlog/set console:ovs_rcu:dbg syslog:ovs_rcu:dbg file:ovs_rcu:dbg
      ovs-appctl vlog/set console:memory:dbg syslog:memory:dbg file:memory:dbg
      ovs-vsctl set Open_vSwitch . other_config={}
      ovs-vsctl --no-wait set Open_vSwitch . other_config:dpdk-socket-mem='8192,8192'
      ovs-vsctl --no-wait set Open_vSwitch . other_config:dpdk-lcore-mask=0x800000000
      ovs-vsctl --no-wait set Open_vSwitch . other_config:pmd-cpu-mask=0xf000000000
      ovs-vsctl --no-wait set Open_vSwitch . other_config:vhost-iommu-support=true
      ovs-vsctl --no-wait set Open_vSwitch . other_config:dpdk-init=true
      driverctl list-overrides | grep '0000:af:00.1 vfio-pci' &>/dev/null || driverctl set-override 0000:af:00.1 vfio-pci
      driverctl list-overrides | grep '0000:af:00.0 vfio-pci' &>/dev/null || driverctl set-override 0000:af:00.0 vfio-pci
      driverctl -v list-overrides
      ovs-vsctl --if-exists del-br bondbridg
      ovs-vsctl --may-exist add-br bondbridge – set bridge bondbridge datapath_type=netdev
      ovs-vsctl set int bondbridge mtu_request=9200
      ovs-ofctl mod-port bondbridge bondbridge up
      ovs-vsctl add-bond bondbridge active-backup ens4f1 ens4f0 lacp=passive bond_mode=active-backup – set Interface ens4f1 type=dpdk options:dpdk-devargs=0000:af:00.1 options:n_rxq=4 options:mtu_request=9200 – set Interface ens4f0 type=dpdk options:dpdk-devargs=0000:af:00.0 options:n_rxq=4 options:mtu_request=9200
      echo $?

      Actual results:

      1. ovs-vsctl add-bond bondbridge active-backup ens4f1 ens4f0 lacp=passive bond_mode=active-backup – set Interface ens4f1 type=dpdk options:dpdk-devargs=0000:af:00.1 options:n_rxq=4 options:mtu_request=9200 – set Interface ens4f0 type=dpdk options:dpdk-devargs=0000:af:00.0 options:n_rxq=4 options:mtu_request=9200
        ovs-vsctl: Error detected while setting up 'ens4f1': Error attaching device '0000:af:00.1' to DPDK. See ovs-vswitchd log for details.
        ovs-vsctl: Error detected while setting up 'ens4f0': Error attaching device '0000:af:00.0' to DPDK. See ovs-vswitchd log for details.
        ovs-vsctl: The default log directory is "/var/log/openvswitch".
      2. echo $?
        0

      Expected results:
      after create failed, the exit status should not equal 0

      Additional info:

              amorenoz@redhat.com Adrian Moreno
              mhou@redhat.com HOU MINXI
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: