-
Task
-
Resolution: Done
-
Undefined
-
None
-
None
-
None
-
5
-
False
-
False
-
rhel-9
-
None
-
rhel-net-ovn
-
-
-
ssg_networking
-
OVN FDP Sprint 11
-
1
The patchwork_check tool is currently only able to set the "Ready" flag on issues when they are posted for review. However, when changes are requested, we would like the "Ready" flag to be removed.
For this change, we need to check for "patch-state-changed" events from patchwork. If a patch is changed to one of the following states:
- Changes Requested
- Not Applicable
- Rejected
- Deferred
Then set the "Ready" flag on the issue to false. For the "Superseded" state, we assume that a new version of the patch has been posted, so we ignore this state. We also ignore the "Handled Elsewhere" state since that is not an indication that the "Ready" flag should be set false. That either may mean that a different review is handling the issue or that the issue should be closed since a different change has fixed it.
Note that the patch that cites the FDP issue may not be the one in the series that has the changes requested. For instance, a 5 patch series may only cite the FDP issue in the final patch. But patches 3 and 4 may have changes requested. If any patch in the series has changes requested, we need to set the "Ready" flag false.
The same is true if multiple Jira issues are cited in a series. If any patch in the series has changes requested, then all issues in the series need to have the "Ready" flag set false.