Uploaded image for project: 'AMQ Streams'
  1. AMQ Streams
  2. ENTMQST-5016

[QE] - Remove explicit specification of the namespace in beforeAll()

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Won't Do
    • Icon: Undefined Undefined
    • 2.5.0.GA
    • None
    • None
    • None

      When we had a class-wide parallelization it was necessary to specify the namespace in beforeAll() because it could interleave between test classes with different test cases (e.g., one thread was verifying UserST with user-namespace-st and another thread TopicST with topic-namespace-st. Thus context was switching and without explicit specification, we would create resources in different and potentially wrong namespaces).

      But after we will remove such parallelization, we can easily remove it and makes the code a little bit simpler.

      f.e.

      resourceManager.createResource(extensionContext, KafkaTemplates.kafkaEphemeral(userClusterName, 1, 1)
                  .editMetadata()
                      .withNamespace(clusterOperator.getDeploymentNamespace())
      see-quick marked this conversation as resolved.
                  .endMetadata()
                  .build());
      
      // should be changed to 
      resourceManager.createResource(extensionContext, KafkaTemplates.kafkaEphemeral(userClusterName, 1, 1) .build());
      

              morsak Maros Orsak
              morsak Maros Orsak
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: