Uploaded image for project: 'AMQ Streams'
  1. AMQ Streams
  2. ENTMQST-4513

Confusing Cruise Control logs when finished KafkaRebalance resource is not deleted

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Undefined Undefined
    • 2.4.0.GA
    • None
    • None
    • None
    • False
    • Hide

      None

      Show
      None
    • False

      When I finish a KafkaRebalance, but don't delete the resource afterward, I always get the following 4 info messages:

      2023-01-05 20:33:47 INFO  AbstractOperator:239 - Reconciliation #106(timer) KafkaRebalance(myproject/my-rebalance): KafkaRebalance my-rebalance will be checked for creation or modification
      2023-01-05 20:33:48 INFO  KafkaRebalanceAssemblyOperator:399 - Reconciliation #106(timer) KafkaRebalance(myproject/my-rebalance): Rebalance action from state [Ready]
      2023-01-05 20:33:48 INFO  KafkaRebalanceAssemblyOperator:436 - Reconciliation #106(timer) KafkaRebalance(myproject/my-rebalance): State updated to [Ready] and annotation strimzi.io/rebalance is not set
      2023-01-05 20:33:48 INFO  AbstractOperator:510 - Reconciliation #106(timer) KafkaRebalance(myproject/my-rebalance): reconciled
      

      The first and last messages make sense ... the rebalance is there, and the periodical recon finds it ... fine. But what do these two really mean?

      2023-01-05 20:33:48 INFO  KafkaRebalanceAssemblyOperator:399 - Reconciliation #106(timer) KafkaRebalance(myproject/my-rebalance): Rebalance action from state [Ready]
      2023-01-05 20:33:48 INFO  KafkaRebalanceAssemblyOperator:436 - Reconciliation #106(timer) KafkaRebalance(myproject/my-rebalance): State updated to [Ready] and annotation strimzi.io/rebalance is not set
      
      • Rebalance action from state [Ready] => that seems like something is missing from the log message
      • State updated to [Ready] and annotation strimzi.io/rebalance is not set => this one makes a bit more sense. But the state was Ready already before, so it was not changed. And I do not really understand what it is trying to say. Should I set the annotation which is not set?

      I think the logging here can be improved to make it more understandable to users and more clear.

      Created by Strimzi#7873.

              Unassigned Unassigned
              scholzj JAkub Scholz
              Lukas Kral Lukas Kral
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Created:
                Updated:
                Resolved: