Uploaded image for project: 'JBoss A-MQ'
  1. JBoss A-MQ
  2. ENTMQ-1030

improve performance of TextFileCertificateLoginModule when many entries are in the "textfiledn.user " file

    Details

    • Type: Enhancement
    • Status: Resolved
    • Priority: Major
    • Resolution: Done
    • Affects Version/s: JBoss A-MQ 6.1
    • Fix Version/s: JBoss A-MQ 6.2.1
    • Component/s: broker
    • Labels:

      Description

      With a large number of entries ( 200,000 ) in the "org.apache.activemq.jaas.textfiledn.user" file the performance seemed to degrade.To demonstrate the performance difference;| ||1) for 100 entries and calling initialize,login(),commit 10 times - Time taken is 73 miliseconds|

       
      2) for 200,000 entries and calling initialize,login(),commit 10 times - Time taken is 5020 miliseconds
       

      Test is attached.Suggested improvements:avoid loading the org.apache.activemq.jaas.textfiledn.user file each time - in PropertiesLoginModule.java, the file is only read when it changes, using the file modification time.avoid iterating through the Properties object, using a Map instead to retrieve the userName

        Gliffy Diagrams

          Attachments

            Activity

              People

              • Assignee:
                garytully Gary Tully
                Reporter:
                pfox Patrick Fox
              • Votes:
                0 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: