-
Bug
-
Resolution: Done
-
Critical
-
jboss-fuse-6.2.1, jboss-fuse-6.3
-
%
-
There is the possibility that errors that happen as part of a containers git pull do not get handled nor logged.
When a git level change is to be propagated to all containers, they all call GitDataStoreImpl.doPullInternal().
This calls pullPushPolicy.doPull().
Now in DefaultPullPushPolicy.doPull() it fairly early logs
Performing a pull on remote URL: ..
However there are code paths that can lead to returning from this method in error conditions but without the error being logged or handled.
If there are any exceptions raised in method DefaultPullPushPolicy.doPull() after calling git.fetch()...call() these result in this code path getting called:
} catch (Exception ex) { return new AbstractPullPolicyResult(ex); }
where the exception is not logged. It returns an AbstractPullPolicyResult instance carrying the exception.
However the calling method GitDataStoreImpl.doPullInternal() has
private PullPolicyResult doPullInternal(GitContext context, CredentialsProvider credentialsProvider, boolean allowVersionDelete) { PullPolicyResult pullResult = pullPushPolicy.doPull(context, credentialsProvider, allowVersionDelete); if (pullResult.getLastException() == null) { ... } return pullResult; }
and in case of an exception, its simply ignored and not handled nor logged.
This may leave the local git repo in an inconsistent state.
- relates to
-
ENTESB-7012 custom profiles are not present in the new profile version after adding patch
- Closed
-
ENTESB-7444 git CheckoutConflictException shortly after container startup
- Closed
-
ENTESB-7342 "InvalidRemoteException: Invalid remote: origin" when patching fabric without jboss-fuse-full profile
- Closed