Uploaded image for project: 'WildFly Elytron'
  1. WildFly Elytron
  2. ELY-653

KeystorePasswordStore contains inconsistency about MODIFIABLE configuration attribute

    XMLWordPrintable

Details

    Description

      KeystorePasswordStore contains inconsistency about MODIFIABLE configuration attribute.

      Here it is used MODIFIABLE attribute:
      https://github.com/wildfly-security/wildfly-elytron/blob/1.1.0.Beta10/src/main/java/org/wildfly/security/credential/store/impl/KeystorePasswordStore.java#L275

      But it is missing between supported configuration attributes:
      https://github.com/wildfly-security/wildfly-elytron/blob/1.1.0.Beta10/src/main/java/org/wildfly/security/credential/store/impl/KeystorePasswordStore.java#L222

      I cannot see any condition with isModifiable() in store() or remove() method:
      https://github.com/wildfly-security/wildfly-elytron/blob/1.1.0.Beta10/src/main/java/org/wildfly/security/credential/store/impl/KeystorePasswordStore.java#L317

      In my opinion MODIFIABLE attribute should be supported otherwise please remove code about MODIFIABLE from initialize() method.

      Attachments

        Issue Links

          Activity

            People

              pskopek@redhat.com Peter Skopek
              hsvabek_jira Hynek Švábek (Inactive)
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: