Uploaded image for project: 'WildFly Elytron'
  1. WildFly Elytron
  2. ELY-612

Missing or unnecessary null check in AbstractDigestMechanism

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 1.1.0.Beta8
    • 1.1.0.Beta7
    • None

      There is missing or unnecessary null check in getSaltedPasswordFromTwoWay method of org.wildfly.security.sasl.digest.AbstractDigestMechanism. char[] passwordChars is assigned on line 650 [1].

      • In case when null can be assigned to passwordChars then there is missing null check before calling userRealmPasswordDigest(messageDigest, username, realm, passwordChars); on line 658 which can result to NPE.
      • In case when null cannot be assigned to passwordChars then there is unnecessary null check on line 659.

      [1] https://github.com/wildfly-security/wildfly-elytron/blob/e01a09572b02f33db01695eb85638e88b0cd944f/src/main/java/org/wildfly/security/sasl/digest/AbstractDigestMechanism.java#L650

            dlloyd@redhat.com David Lloyd
            olukas Ondrej Lukas (Inactive)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: