Uploaded image for project: 'WildFly Elytron'
  1. WildFly Elytron
  2. ELY-2438

Update RawSimpleDigestPassword to make use of MessageDigest#isEqual to avoid a potential timing attack

XMLWordPrintable

      There’s one place in https://github.com/wildfly-security/wildfly-elytron/blob/1.x/credential/base/src/main/java/org/wildfly/security/password/interfaces/RawSimpleDigestPassword.java where Arrays#equals is currently used for byte array comparisons.

      Arrays#equals is vulnerable to timing attacks because it uses a non time-constant comparison.

      MessageDigest#isEqual uses a time-constant comparison which means that all bytes in the arrays will be compared.

      Update RawSimpleDigestPassword so that it uses the MessageDigest#isEqual method instead of Arrays#equals.

              email2keya@gmail.com Keya Sarkar (Inactive)
              fjuma1@redhat.com Farah Juma
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Created:
                Updated:
                Resolved: