Uploaded image for project: 'WildFly Elytron'
  1. WildFly Elytron
  2. ELY-2020

Revisit code style for tool / CredentialStoreCommand

    XMLWordPrintable

Details

    • Task
    • Resolution: Duplicate
    • Major
    • None
    • 1.13.0.CR4
    • Command-Line Tool
    • None

    Description

      This should probably wait until after ELY-1842 as refactoring before will cause more problems.

      Working on ELY-1842 another engineer has also worked on an RFE for different reasons to adjust the credential store, the current code has a long method building up with the options for the command line - if multiple engineers work on this code it leads to conflicts easily but is also hard to unravel to correct the conflicts.

      As the scope of CredentialStoreCommand has expanded since it's original implementation which was very tightly constrained we probably need to break this up into more logical chunks, also many variables just have a very short name which keeps the code concise but if you have not bee in the code for a while it is hard to see the purpose of each variable to we should expand the variable names to be more meaningful.

      Attachments

        Issue Links

          Activity

            People

              darran.lofthouse@redhat.com Darran Lofthouse
              darran.lofthouse@redhat.com Darran Lofthouse
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: