Uploaded image for project: 'WildFly Elytron'
  1. WildFly Elytron
  2. ELY-1664

Trace logging in SSLUtils

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Done
    • Icon: Major Major
    • 1.6.1.Final, 1.7.0.CR1
    • 1.6.0.Final
    • SSL
    • None

      Check Trace logging of ssl context creation. How I read code logging should apply after throw expression. That wouldn never happen. Also there is another throw of exception with SSLUtils::throwIt.

      org.wildfly.security.ssl.SSLUtils
              // now return a factory that will return the best match is can create.
              final String[] supportedProtocols = protocolSelector.evaluate(preferredProviderByAlgorithm.keySet().toArray(NO_STRINGS));
              if (supportedProtocols.length > 0) {
                  return () -> {
                      for (String protocol : supportedProtocols) {
                          List<Provider> providerList = preferredProviderByAlgorithm.getOrDefault(protocol, Collections.emptyList());
                              for (Provider provider : providerList) {
                                  try {
                                      return SSLContext.getInstance(protocol, provider);
                                  } catch (NoSuchAlgorithmException ignored) {}
                              }
                      }
                      throw ElytronMessages.log.noAlgorithmForSslProtocol();
                  };
              }
      
              if (log.isTraceEnabled()) {
                  log.tracef("No %s provided by providers in %s: %s", SERVICE_TYPE, SSLUtils.class.getSimpleName(), Arrays.toString(providerSupplier.get()));
              }
      
              return SSLUtils::throwIt;
      

              jucook Justin Cook (Inactive)
              mchoma@redhat.com Martin Choma
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Created:
                Updated:
                Resolved: