Uploaded image for project: 'WildFly Elytron'
  1. WildFly Elytron
  2. ELY-1483

japicmp detects compatibility issues

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Do
    • Icon: Critical Critical
    • 1.2.0.Final
    • 1.2.0.Beta11
    • API / SPI
    • None

      I have used japicmp tool to compare public API [1]. Version 1.1.7.Final was compared with master HEAD (in time of writing 1.2.0.Beta12-SNAPSHOT). This incompatibility was detected:

      [ERROR] Failed to execute goal com.github.siom79.japicmp:japicmp-maven-plugin:0.11.0:cmp (default) on project wildfly-elytron: Breaking the build because there is at least one incompatibility: org.wildfly.security.auth.server.event.RealmDefiniteOutcomeAuthenticationEvent.RealmDefiniteOutcomeAuthenticationEvent(org.wildfly.security.auth.server.RealmIdentity,org.wildfly.security.credential.Credential,org.wildfly.security.evidence.Evidence):CONSTRUCTOR_LESS_ACCESSIBLE -> [Help 1]
      

      But I would say this is false positive. Looking into ELY-1453 effectively visibility of constructor didn't change. honza889 wdyt?

      False positives because packages asn/x500 were not public in 1.1.7.final :

      • removed org.wildfly.security.asn1.ASN1 (moved to org.wildfly.security.asn1.util)
      • removed org.wildfly.security.asn1.OidsUtil (moved to org.wildfly.security.asn1.util)
      • removed org.wildfly.security.asn1.OidsUtil$Category (moved to org.wildfly.security.asn1.util)
      • removed org.wildfly.security.x500.X500PrincipalUtil (moved to org.wildfly.security.x500.util)
      • removed org.wildfly.security.asn1.ASN1Encoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
      • removed org.wildfly.security.asn1.ASN1Encoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)
      • constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DERDecoder.DERDecoder(org.wildfly.security.util.ByteIterator)
      • constructor less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.DEREncoder(org.wildfly.security.util.ByteIterator)
      • method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeIA5String(org.wildfly.security.util.ByteStringBuilder)
      • method less accessible package_protected (<- public ) org.wildfly.security.asn1.DEREncoder.encodeOctetString(org.wildfly.security.util.ByteStringBuilder)

      [1] https://github.com/wildfly-security/wildfly-elytron/pull/1067

              Unassigned Unassigned
              mchoma@redhat.com Martin Choma
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Created:
                Updated:
                Resolved: