Uploaded image for project: 'WildFly Elytron'
  1. WildFly Elytron
  2. ELY-1479

Coverity, Missing call to superclass in AbstractGssapiMechanism

    XMLWordPrintable

Details

    Description

      super.getNegotiatedProperty() is not called in AbstractGssapiMechanism#getNegotiatedProperty, although it is called in similar cases in Gs2SaslServer, DigestSaslServer, AnonymousSaslClient.

      AbstractGssapiMechanism.java
          @Override
          public Object getNegotiatedProperty(String propName) {
              assertComplete();
      
              switch (propName) {
                  case Sasl.QOP:
                      return selectedQop.getName();
                  case Sasl.MAX_BUFFER:
                      return Integer.toString(actualMaxReceiveBuffer != 0 ? actualMaxReceiveBuffer : configuredMaxReceiveBuffer);
                  case Sasl.RAW_SEND_SIZE:
                      return Integer.toString(maxBuffer);
              }
      
              return null;
          }
      

      This coverity report is not caused by recent change in AbstractGssapiMechanism but rather Gs2SaslServer and DigestSaslServer

      [1] https://scan7.coverity.com/reports.htm#v23632/p11778/fileInstanceId=44847684&defectInstanceId=9457508&mergedDefectId=1463150

      Attachments

        Issue Links

          Activity

            People

              rhn-support-ivassile Ilia Vassilev
              mchoma@redhat.com Martin Choma
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: